Repository navigation
Conversation
Implement attribute-cursor and sibling-skip APIs in PHP-in-PHP (VmXmlReader) to match php-src xmlTextReaderMoveTo* / xmlTextReaderNext semantics. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
Maintainer triage: |
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…19395) Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
agent/ext-xml-19395-moveto-next
branch
from
July 17, 2026 03:41
014c283 to
caa8032
Compare
Owner
Author
|
Closing for DOM/XML lane takeover (wrong owner + merge conflicts). Work preserved on branch agent/ext-xml-19395-moveto-next. |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
XMLReader::moveToAttribute,moveToFirstAttribute,moveToNextAttribute,moveToElement, andnext([string $name])in PHP-in-PHP (VmXmlReader+ attribute cursor onXmlReaderState).ext/xmlreader/php_xmlreader.c/ libxmlxmlTextReaderMoveTo*+xmlTextReaderNext(attribute node view, sibling skip, optional name filter).Closes #19395
php-src reference
zim_XMLReader_moveToAttribute,moveToFirstAttribute,moveToNextAttribute,moveToElement,zim_XMLReader_nextTest plan
name=a attrCount=2…afterNext=b)../script/phpunit.sh --filter XmlReaderTest— OK (10 tests)./script/phpunit.sh --filter move_to_attribute_next— OK (3 assertions)php script/bootstrap-inventory.php --check— OK 5286/5286php script/check-selfhost-spine-coverage-sync.php— OK./script/ci-fast.sh(docker-exec) — exit 0 (auto-healed spine footnotes + inventory)Notes
north-star5-faststill red on master (native execute exit 134) — recorded on Strategic alignment: compiler excellence pillars (2026 H2) #10533; out of DOM/XML exclusive.runtime/*.c.Made with Cursor