Repository navigation
Stdlib: SQLite3Stmt bindParam/getSQL/readOnly + named binds (#19854) - #19858
Merged
Merged
Conversation
4 tasks
PurHur
force-pushed
the
agent/issue-19854-sqlite3-stmt-rest
branch
from
July 17, 2026 03:21
76c2c22 to
7bb5f70
Compare
Restore spine coverage for #19821 stmt/result units and match php-src sqlite3.c bind/getSQL/readOnly/columnType-before-row semantics on VM. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
agent/issue-19854-sqlite3-stmt-rest
branch
from
July 17, 2026 03:23
7bb5f70 to
43273a5
Compare
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SQLite3Stmt::{bindParam,getSQL,readOnly}and named:namebinds forbindValue/bindParam(php-srcext/sqlite3/sqlite3.c).SQLite3Result::columnTypeto returnfalsewhensqlite3_data_countis 0 (before firstfetchArrayafter reset).compiler_lib_spine_smoke(Pillar 1 /north-star5-verify-fast).Closes #19854
php-src reference
ext/sqlite3/sqlite3.c—bindParam/bindValue,getSQL,readOnly,columnTypeext/sqlite3/sqlite3.stub.phpPHP implementation
ext/sqlite3/VmSQLite3Stmt.php,VmSQLite3Result.php,VmSqlite3Native.phplib/BuiltinByRefParams.php—sqlite3stmt::bindparamarg index 2test/selfhost/compiler_lib_spine_smoke/main.phptest/compliance/cases/ext/sqlite3_stmt_bindparam_getsql.phptTest plan
PHP_COMPILER_PROFILE=8.4)php script/check-selfhost-spine-coverage-sync.php→ OK 5288/5288php script/bootstrap-inventory.php --check→ OK 5288/5288sqlite3_stmt_bindparam_getsql|sqlite3_query_prepare|sqlite3_memory→ 6/6make north-star5-verify-fast→ OKVerification transcript
Made with Cursor