Conversation
Add ExamplesCompileTest::test005SessionsWebAotLink with opt-in SESSIONS_WEB_AOT_LINK_GATE (default 0) so phpc build --project link failures surface before execute smoke (#1891). Document gate in doctor, ci-defaults, and examples README run matrix. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExamplesCompileTest::test005SessionsWebAotLink(@group aot-link) —phpc build --projectonexamples/005-SessionsWebwhen LLVM is ready; link-only (no two-request execute).SESSIONS_WEB_AOT_LINK_GATE(default 0 inscript/ci-defaults.env) so CI can opt in before flipping default in CI: Default SESSIONS_WEB_AOT_LINK_GATE=1 in ci-local after #1946 green #1954.phpc doctor --gates,docs/local-ci-matrix.md, and examples README run matrix.Test plan
Verified in Docker (
php-compiler:22.04-dev): link test OK with gate=1; skipped with gate=0.Closes #1946
Made with Cursor