Skip to content

CI: Default SESSIONS_WEB_AOT_LINK_GATE=1 in ci-local after #1946 green #1954

Description

@PurHur

Problem

#1946 adds ExamplesCompileTest coverage for 005-SessionsWeb AOT link only (phpc build --project / bin/compile.php -l). The env gate SESSIONS_WEB_AOT_LINK_GATE defaults to 0 — full ci-local.sh does not exercise 005 link until contributors opt in.

Execute remains #1891 + runtime (#1938 ✅ closed on master; re-open if regressions).

Goal

After test005SessionsWebAotLink passes on php-compiler:22.04-dev:

  1. Default SESSIONS_WEB_AOT_LINK_GATE=1 in script/ci-defaults.env (llvm tail / @group aot-link)
  2. Opt-out SESSIONS_WEB_AOT_LINK_GATE=0 for session-runtime-only PRs
  3. Document in docs/local-ci-matrix.md; extend phpc doctor --gates (DevEx: phpc doctor --gates lists 005-SessionsWeb ladder (#1887–#1894) #1903)
  4. Update examples/README.md run matrix: AOT link ✅ when gate on

Implementation hints

Piece Path
Test test/unit/ExamplesCompileTest.php — from #1946
Defaults script/ci-defaults.env
CI script/ci-local.sh — PHPUnit filter or existing aot-link group
Skip LlvmToolchain::isReady() — exit 0 when LLVM missing

Gate ladder (005)

#1946 link (this flip) → #1891 execute → #1921 opt-in AOT smoke → #1923 default-on

Acceptance criteria

SESSIONS_WEB_AOT_LINK_GATE=1 ./script/ci-local.sh --filter test005SessionsWebAotLink
docker run --rm -v "$(pwd):/compiler" -w /compiler php-compiler:22.04-dev \
  env SESSIONS_WEB_AOT_LINK_GATE=1 ./script/ci-local.sh --filter test005SessionsWebAotLink

No GitHub Actions.

Dependencies

Links

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions