php-in-php: finish JitRename libc defer + AOT is_file kernel (#19215) - #19248
Merged
Conversation
…lper refresh (#19215) Remove user-script AOT inline rename(2) LLVM from JitRename; route through StringRename with JitRenameKernel libc path and stat-cache invalidation. Add phpc_rename_kernel internal for helper-unit lowering without rename() builtin recursion; refresh RenameJitHelper prelink (c2e3d15b9c70bbb71e64). AOT rename execute parity improved (ok+moved); is_file($to) after rename still stale — follow-up for StatPath/StatCache helper TU coherence. Co-authored-by: Cursor <cursoragent@cursor.com>
Delete JitRename::invokeLibc (prior). User-script AOT rename uses JitRenameKernel; embed keeps RenameJitHelper. Fix AOT is_file/file_exists via thin JitStatKernel in StatPathRuntime (nested VmStatPath stubs). Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 15, 2026
Resolve docs/bootstrap-inventory.md conflict (ours; regenerate after lock). Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JitRename::invokeLibcdeleted; user-script AOT rename via thinJitRenameKernellibc; embed keepsRenameJitHelperviaJitVmHelperLink.RenameBuiltinTest: user-scriptis_file/file_existswere always false because nestedStatPathJitHelpersawVmStatPathas external stubs.StatPathRuntimenow emitsJitStatKernel(thin libcstat/access) underUserScriptAotDeferNestedJit.OK 4923/4923).Closes #19215.
Lines removed / C surface
JitRename::invokeLibc(~20 lines inline libc LLVM) — prior commit on this lineage.JitRenameKernel,JitStatKernel) instead of growingJitStatglibc layout (php-in-php: JitStat — route is_file/is_dir/file_exists/is_link LLVM through VmStatPath not libc stat FFI (#1492, pairs #8903) #9112 shrink preserved).Verification
php-src ref:
ext/standard/filestat.c(php_rename, path predicates).Made with Cursor