php-in-php: delete JitRename libc defer — kernel bridge (#19215) - #19228
Closed
PurHur wants to merge 1 commit into
Closed
php-in-php: delete JitRename libc defer — kernel bridge (#19215)#19228PurHur wants to merge 1 commit into
PurHur wants to merge 1 commit into
Conversation
…lper refresh (#19215) Remove user-script AOT inline rename(2) LLVM from JitRename; route through StringRename with JitRenameKernel libc path and stat-cache invalidation. Add phpc_rename_kernel internal for helper-unit lowering without rename() builtin recursion; refresh RenameJitHelper prelink (c2e3d15b9c70bbb71e64). AOT rename execute parity improved (ok+moved); is_file($to) after rename still stale — follow-up for StatPath/StatCache helper TU coherence. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
Maintainer: holding merge — AOT |
Owner
Author
|
Superseded by #19248 (AOT is_file kernel + rename done-when green). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JitRename::invokeLibcandUserScriptAotDeferNestedJitdefer from the rename JIT path;JitRenamealways delegates toStringRename.StringRenamebridge now callsJitRenameKernel(thin libcrename(2)) and invalidates stat cache viaStatCacheJitHelper::clearPathafter success.@internalphpc_rename_kernel+JitRenameKernelsoRenameJitHelperhelper units avoidrename()builtin recursion; refresh prelinkedRenameJitHelperunit (c2e3d15b9c70bbb71e64).C removed: ~20 lines
invokeLibcLLVM fromext/standard/JitRename.php.Verification
RenameRuntimeShrinkTest— OK (Zend delegate test skipped; source guards OK)RenameBuiltinTest::testVmMatchesPhpSubset— OKbootstrap-selfhost-vm-driver-execute-probe— OKRenameBuiltinTest::testAotNativeBinaryMatchesPhpSubset— partial:rename()returns true (ok+moved), butis_file($to)stillnonew(stat cache coherence across prelinked StatPath vs StatCache helper TUs; same shape as master libc defer)Merge status
Not merging — AOT repro not fully green (
is_file($to)after successful rename). Follow-up needed on helper-runtime VmStatCache TU coherence before closing #19215.Closes #19215 when follow-up lands.
Made with Cursor