Testing: 005-SessionsWeb in examples-web-smoke + CI gate (#1887) - #1917
Merged
Conversation
Add SESSIONS_WEB_SMOKE_GATE (default on) with cookie-jar curls in ci-fast/ci-local, PHPUnit serve flash round-trip, and fix bin/serve.php to persist sessions on exit. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SESSIONS_WEB_SMOKE_GATE=1(default) toci-fast.shandci-local.shviaci_run_sessions_web_smoke/examples-web-smoke.sh --sessions-only.examples-web-smoke.shwith cookie-jar curls for POST→303→GET flash round-trip onexamples/005-SessionsWeb.ExamplesCompileTest::test005SessionsWebServeFlashRoundTrip(@group serve) andmake examples-sessions-smoke.bin/serve.phpto treatexitas a normal response and persist VM sessions (ScriptExit+VmSession::writeClose).Test plan
SESSIONS_WEB_SMOKE_GATE=1 ./script/examples-web-smoke.sh --sessions-only(Docker tar harness)vendor/bin/phpunit --filter 'test005SessionsWebServeFlashRoundTrip|ExamplesWebSmokeScriptTest|CiScriptsTest::testCiFastRunsSessionsWebSmokeGate'./script/ci-fast.shon a host with stable inventory sync (harness Docker may fail doc sync gates after auto-regeneratingbootstrap-inventory.md)Closes #1887
Made with Cursor