Skip to content

DevEx: make examples-sessions-smoke — VM curl ladder for 005-SessionsWeb (#1887) #1914

Description

@PurHur

Problem

#1887 adds 005-SessionsWeb to script/examples-web-smoke.sh and ExamplesCompileTest, but contributors running ad-hoc checks must remember env vars (SESSIONS_WEB_SMOKE_GATE) and curl cookie-jar flags. 001–004 have ergonomic make examples-web-smoke; 005 needs a named target for presenters and #1903 phpc doctor --gates.

Goal

make examples-sessions-smoke    # VM only: phpc serve + two-request session curl
SESSIONS_WEB_SMOKE_GATE=1 make examples-sessions-smoke  # same as ci-fast when gate on

Prints actionable failure (route, Set-Cookie, flash message) on stderr.

Implementation hints

Piece Path Notes
Script script/examples-sessions-smoke.sh Mirror examples-web-smoke.sh structure; cookie jar in /tmp
Makefile Makefile examples-sessions-smoke: target calling script
Serve bin/serve.php / phpc serve examples/005-SessionsWeb docroot
Curls script (1) GET home (2) POST set flash (3) GET redirect shows flash
CI #1887 ci-fast.sh calls script when SESSIONS_WEB_SMOKE_GATE=1
Doctor #1903 List step after #1887 green
Docs examples/005-SessionsWeb/README.md Copy-paste curl block (#1881)

Env / gates

# script/ci-defaults.env (owned by #1894)
SESSIONS_WEB_SMOKE_GATE="${SESSIONS_WEB_SMOKE_GATE:-0}"

Flip default-on in #1894 after this target is stable.

Acceptance criteria

make examples-sessions-smoke
# exit 0; stdout contains flash message needle

With tree missing, target prints skip hint linking #1881.

Verification (local / Docker only)

docker run --rm -v "$(pwd):/compiler" -w /compiler php-compiler:22.04-dev \
  make examples-sessions-smoke

Dependencies

Links

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions