Repository navigation
Fix AOT CGI superglobal refresh: QUERY_STRING populates $_GET (closes #18832) - #18841
Merged
Merged
Conversation
…rse LLVM (#18832). Nested ParseStrNativeJitHelper JIT under PHP_COMPILER_AOT_USER_SCRIPT produces no-op stubs during thin user-script init (#18643 regression). Restore init-safe ParseStrUserScriptDelimitedJit and call __phpc_parse_str_parse_delimited_pairs directly from SuperglobalRefreshUserScriptLlvm for $_GET/$_REQUEST/$_COOKIE. Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
3 tasks
PurHur
added a commit
that referenced
this pull request
Jul 14, 2026
…fix (#18847) ParseStrUserScriptDelimitedJit was restored for init-safe libc C-string parsing in user-script AOT superglobal refresh; update shrink tests that still asserted the file was deleted. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
added a commit
that referenced
this pull request
Jul 14, 2026
…fault (#18841 follow-up). (#18849) Nested LLVM parse_key_brackets/set_nested_value crashes on runtime refresh strings; skipping bracket pairs lets flat keys in mixed queries parse (NestedSuperglobalsAotTest). Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParseStrUserScriptDelimitedJitLLVM delimited parser removed in php-in-php: re-delete ParseStrUserScriptDelimitedJit — MultipartRuntime PHP makes #18548 LLVM restore obsolete (#1492) #18643__superglobals__refreshform/cookie parsing through__phpc_parse_str_parse_delimited_pairson raw libc C strings instead of broken nestedParseStrNativeJitHelperstubsexamples/001-SimpleWebAOT smoke:QUERY_STRING=name=Smokenow yields<h1>Hello Smoke</h1>Root cause
Under
PHP_COMPILER_AOT_USER_SCRIPT=1, nested JIT ofParseStrNativeJitHelperduring thin standalone init emits single-block no-op helpers.__compiler_parse_strbridge called those stubs, so$_GET/$_REQUESTstayed empty while$_SERVER['QUERY_STRING']was set correctly.Verification
Closes #18832
Made with Cursor