Repository navigation
php-in-php: delete ParseStrUserScriptDelimitedJit — route refresh through ParseStrRuntime (#18855) - #18872
Merged
Conversation
3 tasks
Owner
Author
|
Maintainer verification: do not merge — reprobed locally.
Next step remains fixing |
…er_parse_str (#18855). SuperglobalRefreshUserScriptLlvm now calls __compiler_parse_str / __compiler_parse_cookie_header via cstrToPhpcString instead of linking hand-LLVM subhelpers directly. User-script bridges in ParseStrRuntime extract native cstr from __string__* and delegate to ParseStrRuntimeUserScriptCstr until nested ParseStrNativeJitHelper works from refresh LLVM (#18872). Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
agent/issue-18855-delete-parse-str-delimited-jit
branch
from
July 14, 2026 13:15
90cd62d to
9299324
Compare
PurHur
added a commit
that referenced
this pull request
Jul 14, 2026
…18899) Add ParseStrRuntimeUserScriptCstr and TraitSelfClassScope to compiler_lib_spine_smoke so inventory/spine sync is 4852/4852 again; update shrink guard and regenerated footnotes. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
added a commit
that referenced
this pull request
Jul 15, 2026
Restore user-script __compiler_parse_str v8 bridges when embed ParseStrJitHelper bodies are linked first (post-#18872 regression). Route 001-SimpleWeb through inline ($_REQUEST['name'] ?? '') echo until superglobal-local + htmlspecialchars JIT is fixed separately. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/JIT/Builtin/ParseStrUserScriptDelimitedJit.php; relocate LLVM delimited lowering toParseStrRuntimeUserScriptCstrlinked only fromParseStrRuntimeuser-script bridgesSuperglobalRefreshUserScriptLlvmform/cookie parsing throughcstrToPhpcString()→__compiler_parse_str/__compiler_parse_cookie_header(no direct__phpc_parse_str_*calls in refresh)__compiler_parse_strbridge extracts native cstr from__string__*and calls LLVM delimited parser (nestedParseStrNativeJitHelperremains blocked from refresh LLVM — php-in-php: delete ParseStrUserScriptDelimitedJit — route refresh through ParseStrRuntime (#18855) #18872)php-src reference
ext/standard/basic_functions.c—PHP_FUNCTION(parse_str)Verification
Closes #18855