Repository navigation
Stdlib: advertise readonly() on PHP_COMPILER_PROFILE=8.4 (#17693) - #17700
Merged
Merged
Conversation
Forward 8.4 profile now matches Zend introspection: function_exists('readonly')
returns true while reference 8.4.0-dev profile keeps the phantom gate.
Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompilerVersion::advertisesReadonlyBuiltin()with the forward-profile pattern used byadvertisesZendThreadId(): onPHP_COMPILER_PROFILE=8.4,function_exists('readonly')is nowtrue.8.4.0-devprofile (no forward profile) still withholdsreadonlyfrom introspection to match Zend 8.2 phantom gate.Root cause
advertisesReadonlyBuiltin()only checked stableCompilerVersion::VERSION >= 8.4.0, so forward-profile callers could invokereadonly($o)butfunction_exists('readonly')returned false.php-src reference
ext/standard/basic_functions.c—PHP_FUNCTION(readonly)registration on PHP 8.4+PHP implementation
lib/CompilerVersion.php— introspection gateext/standard/BuiltinIntrospectionPolicy.php— unchanged (already routes through gate)C runtime shrink
No new C; introspection-only PHP gate fix.
Verification
Closes #17693
Made with Cursor