Repository navigation
fix(stdlib): restore VmFilestatArg InternalStrictArg import (#17155) - #17156
Merged
Merged
Conversation
Commit 710cebc dropped the use statement while parseFileModeArgForFrame() still calls InternalStrictArg::isCallerStrict(), breaking chmod()/mkdir() string mode coercion with a fatal class-not-found error. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use PHPCompiler\VM\InternalStrictArg;inVmFilestatArg.phpafter Stdlib: coerce null path args in filestat builtins (#17006) #17152 accidentally removed it while leavingisCallerStrict()calls inparseFileModeArgForFrame()/requireIntOrStringArgForFrame().Class "PHPCompiler\ext\standard\InternalStrictArg" not foundonchmod($f, '0644')and restores Zend string-mode coercion ('0644'→ mode204).Root cause commit:
710cebce3(#17152).Verification
Closes #17155
Made with Cursor