Repository navigation
Stdlib: coerce null path args in filestat builtins (#17006) - #17152
Merged
Merged
Conversation
Match php-src Z_PARAM_PATH null-to-empty-string behavior for file/path builtins across VM and JIT/AOT, and update strict_types compliance cases accordingly. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17006
Summary
Z_PARAM_PATHnull →''coercion (noTypeError) in both VM and JIT/AOT lowering.TypeErrorfor these builtins.Verification
source script/php-env.sh && php bin/vm.php test/repro/maintainer_gap_file_stat_null_coerce.phpsource script/php-env.sh && php bin/compile.php -l test/repro/maintainer_gap_file_stat_null_coerce.php(took ~2m10s on this host)source script/php-env.sh && php bin/jit.php test/repro/maintainer_gap_file_stat_null_coerce.phpsource script/php-env.sh && php -d memory_limit=1536M vendor/bin/phpunit --filter \"file_stat_null_coerce|path_null_strict_filestat|filestat_is_null_strict_typeerror\"Made with Cursor