Repository navigation
Language: fix enum <=> var_dump ARG_SEND misbind (#10203) - #15937
Merged
Merged
Conversation
var_dump(E::A <=> E::B) wired the hoisted enum-case temp instead of the spaceship result. Prefer the immediate comparison CFG prelude in compileCallArgSends and include it in precedingInlineCallArgProducers. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
3 tasks
PurHur
added a commit
that referenced
this pull request
Jul 4, 2026
…G ops (#15816) (#15941) #15937 added immediate-prelude comparison wiring that passed Echo_ terminals into a ?Expr-only helper, causing compile-time TypeError on var_dump() and other multi-arg calls. Accept mixed and return false for non-Expr nodes so the existing #15823 ternary phi slot wiring can run again. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regression of #10203 / re-#9796:
var_dump(E::A <=> E::B)printedenum(E::B)instead ofint(1)becauseTYPE_ARG_SENDwired a hoisted enum-case temp instead of the spaceship result slot.precedingInlineCallArgProducersBeforeCfgOpwhen they directly precede the consumer callcompileCallArgSendspass prefers the immediate spaceship/relational prelude for dead inline temporariesphp-src reference:
Zend/zend_enum.c—zend_compare_enum/ spaceship on backed enum cases.Verification
Closes #10203
Made with Cursor