Repository navigation
Language: fix consecutive ?: call-arg misbind (#15816) - #15823
Merged
Merged
Conversation
Recognize ?: merge blocks whose arms assign to a shared temporary and wire each dead inline call-arg temp to the matching innermost phi slot so pair()/sprintf()/var_dump() multi-arg ?: operands match Zend. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
4 tasks
This was referenced Jul 4, 2026
PurHur
added a commit
that referenced
this pull request
Jul 4, 2026
…G ops (#15816) (#15941) #15937 added immediate-prelude comparison wiring that passed Echo_ terminals into a ?Expr-only helper, causing compile-time TypeError on var_dump() and other multi-arg calls. Accept mixed and return false for non-Expr nodes so the existing #15823 ternary phi slot wiring can run again. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes multi-arg calls where consecutive
?:operands were misbound to the innermost merge phi — e.g.pair(true ? 'yes' : 'no', false ? 1 : 2)evaluated as$b,$binstead of$a,$b.?:merge blocks viamergeCfgBlockUsesTernaryBranchLiteralAssign()(arms assign to shared temp; php-srcZend/zend_compile.c).resolveNestedTernaryMergeCallArgSlot()beforeTYPE_ARG_SEND.php-src reference
Zend/zend_compile.c— call argument emission /?:merge temporariesZend/zend_execute.c—ZEND_CALLframe slotsVerification
Output (VM/JIT match Zend):
PHPUnit:
OK (2 tests, 2 assertions)(VM + JIT compliance).Closes #15816
Made with Cursor