Repository navigation
php-in-php: chmod() JIT via ChmodJitHelper PHP — drop libc LLVM (#15458) - #15459
Merged
Merged
Conversation
Replace libc chmod(2) LLVM in JitChmod with VmFs SSOT via compiled PHP helper and StringChmod bridge; shrink JitChmod 70→22 LOC. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chmod()throughChmodJitHelper→VmFs::chmod()instead of libcchmod(2)LLVM inJitChmod.php.StringChmodthin ABI bridge (__phpc_jit_chmod) following readlink/realpath pattern (php-in-php: readlink() JIT via ReadlinkJitHelper PHP — drop libc readlink LLVM in JitReadlink.php #15353, php-in-php: realpath() JIT via RealpathJitHelper PHP — drop libc realpath/strlen LLVM in JitRealpath.php #15323).ext/standard/JitChmod.php70 → 22 LOC (−48 lines of inline LLVM +__compiler_trigger_error).php-src reference
ext/standard/filestat.c—php_chmodVerification
Closes #15458
Made with Cursor