Repository navigation
Fix dynamic property deprecation compliance guard (#14839) - #14840
Merged
Merged
Conversation
…14839). The VM and JIT already emit E_DEPRECATED on undeclared writes; update the phpt expectation to allow the standard file/line suffix so the guard stays green. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #14839.
Dynamic property
E_DEPRECATEDon undeclared writes was already implemented inlib/VM.php(fetchObjectPropertyWriteLvalue) andlib/JIT/DynamicPropertyDeprecationGuard.php. This PR fixes the compliance phpt expectation so the guard matches CLI stderr formatting (file/line suffix).Verification
Issue repro (php-src-strict,
error_reporting=E_ALL):Output:
Compliance + unit guards:
All OK (3 tests).
stdClassremains exempt (no deprecation on dynamic writes).Made with Cursor