Stdlib: sin/cos/tan and compiler test fixes - #11
Merged
Conversation
Add trigonometric builtins with PHPT specs, rewrite decbin as a native Internal function, support INF/NAN constants in the VM, and fix compliance test execution (extension loading, cwd, RealWorldTest setUp). Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sin(),cos(), andtan()to the standard extension with compliance and integration PHPT specs.decbin()as a native Internal implementation (fixes runtime failure from compiled-PHP namespaced calls).INFandNANconstants in the VM and implementVM::raise()for clearer constant-fetch errors.proc_open, and fixRealWorldTestmissingsetUp().Test plan
PHP_COMPILER_EXT_DIR=/usr/lib/php/20220829 php vendor/bin/phpunit(167 tests, 76 JIT skipped without LLVM)Made with Cursor