Repository navigation
php-in-php: route JIT random_bytes through RandomBytesJitHelper PHP (#9149) - #10921
Merged
Merged
Conversation
…9149) Replace ~140-line /dev/urandom open/read LLVM in StringRandomBytes with a thin bridge to VmRandomPure via compiled RandomBytesJitHelper. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jun 23, 2026
PurHur
added a commit
that referenced
this pull request
Jun 23, 2026
… JIT helpers (#10924) Regenerate docs/bootstrap-inventory.md (2949→2951 vm.php-path files) and add GetcwdJitHelper/GetcwdJit to compiler_lib_spine_smoke so spine coverage stays complete after recent php-in-php JIT helper splits (#10921, #10922). Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ext/standard/RandomBytesJitHelper.phpdelegating toVmRandomPure::randomBytes()(php-src:ext/standard/random.c)lib/JIT/Builtin/StringRandomBytes.php/dev/urandomopen/readLLVM (~140 lines) with thin JIT bridge calling compiled PHP helperStringRandomBytes.php140 → 103 lines; removed allopen/read/closeLLVMCloses #9149
php-src reference
ext/standard/random.c—php_random_bytes()ext/standard/VmRandomPure.phpviaRandomBytesJitHelper.phpVerification
Made with Cursor