Repository navigation
Reject new in class constant initializers to match Zend (#10391) - #10559
Merged
Merged
Conversation
php-src rejects all `new` in class const expressions at compile time; #10206 incorrectly re-enabled them. Restore the gate in NewWithoutParensCompileCheck and retire supportsClassConstObjectExpressions. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
newexpressions in class constant initializers viaNewWithoutParensCompileCheck(php-src:Zend/zend_compile.czend_compile_const_expr()).newexpressions in class constant initializers (#10198) #10206 allowance;CompilerVersion::supportsClassConstObjectExpressions()now always returnsfalse.Closes #10391
php-src reference
Zend/zend_compile.c— class constantnewexpression validationZend/zend_constants.c— constant object materialization (indirect via global const only)PHP implementation
lib/Compiler/NewWithoutParensCompileCheck.php— walksConst_terminals and rejects nestedNew_lib/CompilerVersion.php— deprecatessupportsClassConstObjectExpressions()Verification
Output (2026-06-22)
Made with Cursor