Repository navigation
Allow new expressions in class constant initializers (#10198) - #10206
Merged
Merged
Conversation
This was referenced Jun 20, 2026
PurHur
added a commit
that referenced
this pull request
Jun 22, 2026
…10559) php-src rejects all `new` in class const expressions at compile time; #10206 incorrectly re-enabled them. Restore the gate in NewWithoutParensCompileCheck and retire supportsClassConstObjectExpressions. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
newexpressions in class constant initializers by removing the stale compile-time rejection inNewWithoutParensCompileCheck(static propertynewdefaults remain forbidden).CompilerVersion::supportsClassConstObjectExpressions()to true on 8.3+ target; existing VM/JIT materialization path (finalizePendingNewClassConst,ClassConstMaterializer) handles runtime object constants with shared identity.php-src reference
Zend/zend_compile.c—zend_compile_const_expr(),ZEND_AST_NEWin constant context (PHP 8.3+)Zend/zend_constants.c— object-typed class constantsVerification
Issue repro:
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php test/repro/maintainer_gap_new_in_constant.php'Object identity:
PHPUnit:
Closes #10198
Made with Cursor