AOT-safe UndefinedVariableJitHelper guards (#10524) - #10543
Merged
Merged
Conversation
3 tasks
Owner
Author
|
Maintainer triage (2026-06-22):
|
Owner
Author
|
Maintainer verify 2026-06-22 (branch tip
Not merged: Closes #10524 when green on master. |
…ted-compile guards (#10524). Avoid re-implementing StringTriggerError when __compiler_trigger_error is already linked in standalone modules. Skip scope-var JIT guards when nested php-in-PHP helper compiles set PHP_COMPILER_SELFHOST_AOT=0 so ObGzhandler bootstrap does not fatal. Context documents omitting ensureStandaloneBodies for this runtime. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
agent/issue-10524-undefined-var-jit-helper
branch
from
June 22, 2026 18:09
5d0901b to
b619f5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StringTriggerErrorJit::implementwhen__compiler_trigger_erroris already linked in standalone modules (avoids corrupt LLVM module / verify failures on 000-HelloWorld).NestedJitCompileScope(PHP_COMPILER_SELFHOST_AOT=0) so nested ObGzhandler bootstrap does not fatal.ContextthatUndefinedVariableRuntime::ensureStandaloneBodiesis intentionally omitted (StringTriggerError already linked).UndefinedVariableRuntime::emitWarningForName()→UndefinedVariableJitHelper::warningMessage()SSOT +__compiler_trigger_error(no compiled helper bridge ABI mismatch).php-src reference
Zend/zend_execute.c—ZEND_CHECK_UNDEFINED_VARlib/VM/UndefinedVariableJitHelper.php,lib/JIT/Builtin/UndefinedVariableRuntime.phpVerification
Results (2026-06-22):
UndefinedVariableRuntimeShrinkTest— OK (4 tests)ScalarDimFetchRuntimeStandaloneTest— OK (1 test)examples-aot-smoke— ok (000–006, 008–009 default slice)Closes #10524