php-in-php: ErrorRaise/TypeErrorRaise pending buffer via JIT helpers (#9778) - #10520
Merged
Merged
Conversation
…T helpers (#9778) Move catchable Error/TypeError pending state from per-module LLVM globals into ErrorRaiseJitHelper and TypeErrorRaiseJitHelper PHP SSOT; JIT/AOT bridges call compiled helpers at link time (compileInPlace) with nested-compile isolation matching ObGzhandler (#8559). Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ext/standard/ErrorRaiseJitHelper.phpandext/standard/TypeErrorRaiseJitHelper.phpinstead of per-module LLVM globals (phpc_jit_error_pending_*,phpc_jit_type_error_pending_*).ErrorRaise.php/TypeErrorRaise.phpnow emit thin LLVM bridges (raise/has/clear/copy) that call compiled PHP helpers; bodies link atContext::compileInPlace()after user IR is lowered.CallArgvinit, and hashtable decls before compile (ObGzhandler pattern).php-src ref:
Zend/zend_exceptions.c—zend_throw_error, catchable Error/TypeError dispatchLLVM removed:
registerPendingGlobals/implementRaiseFunction/ globalmemcpypending buffers in both modulesVerification
Closes #9778
Made with Cursor