Language: clone-with syntax clone($obj, ['prop']) — parse + selective reinit missing (PHP 8.5, Zend/zend_language_parser.y)

[PurHur]

Category

language · php-src-strict

Problem

PHP 8.5 adds clone-with syntax: clone($object, ['prop1', 'prop2']) clones $object and re-initializes only the listed properties from the source (see RFC / php-src clone grammar extension).

This compiler accepts a plain clone $obj but does not parse parenthesized clone-with:

$w2 = clone($w, ['a']); // Zend: selective reinit; VM today: parse error OR wrong lowering

Maintainer repro (test/repro/maintainer_gap_clone_with_syntax.php) shows VM prints 1,2 while Zend rejects with parse error on the comma form — grammar/lowering for clone-with is missing.

php-src reference

• php/php-src Zend/zend_language_parser.y — clone-with production
• php/php-src Zend/zend_compile.c — clone lowering + property reinit list
• php/php-src Zend/zend_closures.c / object handlers — zend_objects_clone_obj selective init

Repro

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php bin/vm.php test/repro/maintainer_gap_clone_with_syntax.php 2>&1 | head -3
php test/repro/maintainer_gap_clone_with_syntax.php 2>&1 | head -3
'

Runtime	Result
Zend PHP 8.5+	Parses clone-with; reinit listed props only
bin/vm.php (today)	Wrong — legacy clone path or parse failure

Scope (this repo) — PHP-in-PHP first

Layer	Path
Parser	php-cfg / lib/SourcePreprocessor/ — clone ( … , [ … ])
Compiler	lib/Compiler.php — lower to clone + property reinit op sequence
VM	lib/VM.php — selective property copy from source
JIT/AOT	reuse clone lowering; follow CloneWithJitHelper (#9717) when emit-helper path exists
Tests	new test/compliance/cases/language/clone_with_basic.phpt

No new C runtime branches — clone-with is compile-time sugar + VM object copy.

Done when

• Repro compiles on VM and output matches Zend PHP 8.5+ for selective reinit
• readonly props in reinit list follow php-src rules
• JIT/AOT agree with VM on repro (or documented follow-up)
• ./script/ci-fast.sh --filter clone_with green

Related

• php-in-PHP emit helper php-in-php: AOT CloneWithReinitRuntimeLlvm — route standalone clone-with reinit through CloneWithJitHelper PHP (#1492) #9717 · North star #1492

[PurHur]

claim: worker-lane-c — starting this run

[PurHur]

Verified fixed on master (2026-06-19) — no code change required this run.

Implementation: lib/Ast/CloneWithDesugar.php desugars clone($obj, ['prop']) / clone($obj, ['prop' => val]) to IIFE + phpc_clone_with_begin/end (same path as clone $obj with { }, #4513/#9743). Wired in lib/Runtime.php pre-parse desugar pass.

Verification (all green):

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php bin/vm.php test/repro/maintainer_gap_clone_with_syntax.php   # 1,2
php bin/jit.php test/repro/maintainer_gap_clone_with_syntax.php  # 1,2
php vendor/bin/phpunit test/unit/CloneWithTest.php                 # 8/8
php vendor/bin/phpunit --filter clone_with test/compliance/VMTest.php  # 5/5
php vendor/bin/phpunit --filter clone_with_syntax test/compliance/JITTest.php  # 1/1
'

Compliance guard: test/compliance/cases/language/clone_with_syntax.phpt (#9743).

Note: Docker Zend PHP 8.2 rejects clone($w, ['a']) parse (expected — feature is PHP 8.5+). VM/JIT semantics match php-src-strict selective reinit (1,2 with readonly b preserved).

Follow-up (out of scope here): standalone AOT bin/compile.php hits LLVM null block in JitCloneWithReinit::begin — tracked separately if needed (#9717 emit-helper path).

Closing as duplicate-of-fixed / stale filing.

[PurHur]

Closed: already implemented via CloneWithDesugar (#9743); repro + compliance green on VM/JIT.