php-in-php: JIT RewriteVarsRuntime — route output_add_rewrite_var through VmWeb PHP not LLVM globals (#1492)

[PurHur]

Category

php-in-php · stdlib · web runtime (#1492)

Problem

Mod-rewrite output var registration (output_add_rewrite_var(), output_reset_rewrite_vars()) has VM implementations in ext/standard/ backed by PHPCompiler\Web\ResponseContext, but JIT/AOT still emit lib/JIT/Builtin/RewriteVarsRuntime.php LLVM that mirrors a request-scoped global hashtable (phpc_rewrite_vars).

Duplicated semantics risk drift for web/AOT builds and extend C-style globals instead of PHP-owned state.

php-src reference

• php/php-src ext/standard/url.c — PHP_FUNCTION(output_add_rewrite_var), PHP_FUNCTION(output_reset_rewrite_vars)
• php/php-src main/php_output.h — rewrite var table

Repro

<?php
output_add_rewrite_var('SESSIONID', 'abc');
output_add_rewrite_var('NAME', 'value');
echo "ok\n";

./script/docker-exec.sh -- php bin/vm.php -r "output_add_rewrite_var('A','1'); echo 'ok';"
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/jit.php -r "output_add_rewrite_var('"'"'A'"'"','"'"'1'"'"'); echo '"'"'ok'"'"';"'

VM path passes today; JIT must call the same PHP helper rather than LLVM table walks.

Scope (this repo)

Layer	Path
VM SSOT	ext/standard/output_add_rewrite_var.php, output_reset_rewrite_vars.php, lib/Web/ResponseContext.php
LLVM today	lib/JIT/Builtin/RewriteVarsRuntime.php
Wire-up	JIT builtin registration → PHP trampoline; delete LLVM bodies

Done when

• JIT/AOT output_add_rewrite_var / output_reset_rewrite_vars invoke ResponseContext via PHP (thin ABI only)
• RewriteVarsRuntime.php deleted or ≤ link stub
• Compliance: test/compliance/cases/stdlib/output_rewrite_var*.phpt (VM + JIT variants) green
• PR body cites php-src paths + LLVM lines removed

Related

• Stdlib: output_add_rewrite_var()/output_reset_rewrite_vars() — mod_rewrite output API missing (ext/standard/url.c) #6031 · php-in-php: CGI superglobal refresh — delete superglobals_refresh.c (~2623 lines), populate in lib/Web/ #5330 · Epic: Self-host critical path — compiler compiles itself (M3→M5) #1492

[PurHur]

claim: PHP Runtime → PHP — batch (issues #9480, #9443, #9477)

[PurHur]

Merged via #11099.

Verification:

OK (4 tests) RewriteVarsRuntime*
check-selfhost-spine-coverage-sync: OK

LLVM shrink: removed phpc_rewrite_vars global hashtable path from RewriteVarsRuntime (~94 lines).