Regression: highlight_string()/highlight_file() — literal true second arg throws LogicException (ext/standard/url.c)

[PurHur]

Summary

highlight_string($code, true) and highlight_file($path, true) fatal with LogicException: highlight_string() expects bool for argument 2 when the second argument is a boolean literal (true/false). Zend accepts the call and returns an HTML string.

Repro

./script/docker-exec.sh -- bash -lc 'php test/repro/maintainer_gap_highlight_string_bool.php'
./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/maintainer_gap_highlight_string_bool.php'

Zend (host/php):

type:string
len:222
has_span:yes

This compiler (VM):

PHP Fatal error: Uncaught LogicException: highlight_string() expects bool for argument 2 in this compiler build

php-src reference

• ext/standard/url.c — PHP_FUNCTION(highlight_string) / highlight_file
• Second parameter $return is zend_parse_parameters type b (bool); literals must work.

Implementation (PHP-in-PHP)

• ext/standard/highlight_string.php — resolveIndirect() type check rejects bool literals passed as arg Php stdlib specs implementation #2; align with Zend coercion / Variable::TYPE_BOOLEAN for literal operands.
• Mirror fix in highlight_file.php / show_source alias if shared path.
• ext/standard/JitHighlight.php if JIT has same guard.

Done when (php-src-strict)

• php bin/vm.php test/repro/maintainer_gap_highlight_string_bool.php matches Zend output.
• Add narrow compliance guard under test/compliance/ or extend existing highlight tests.
• JIT/AOT agree when in scope.

Related

Regression of closed #3164 / #4824 / #6486.

[PurHur]

claim: PHP Compiler STD Lib — starting this run

[PurHur]

Unclaiming: bool literal LogicException no longer reproduces on master (VM+JIT return string HTML). Remaining gap is highlight HTML shape (no <span tags) — separate from filed regression. Switching to #9143 array_map(null).

[PurHur]

claim: cursor-agent-lane-c — starting this run (inline true literal still LogicException on master 2026-06-18)

[PurHur]

Merged via #9640.

Fix: php-cfg hoisted true/false ConstFetch preludes now fold into call-arg slots; VM uses VmHighlight::resolveReturnFlag() for $return.

Verification (Docker):

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php bin/vm.php test/repro/maintainer_gap_highlight_string_bool.php
php bin/vm.php test/compliance/cases/stdlib/highlight_run.php
vendor/bin/phpunit test/compliance/cases/stdlib/highlight_string_bool_literal.phpt
'

All green — highlight_run.php exit 0.