Stdlib: highlight_string()/highlight_file()/show_source() — enum operands must TypeError not LogicException (ext/standard/url.c, php-src-strict)

[PurHur]

Category

stdlib · php-src-strict

Problem

highlight_string(), highlight_file(), and show_source() reject non-string operands with LogicException in VM today. Zend/php-src raises catchable TypeError with must be of type string, E given when an enum case is passed — required for parity with other string builtins (#5524 family).

php-src reference

• php/php-src ext/standard/url.c — PHP_FUNCTION(highlight_string), PHP_FUNCTION(highlight_file)
• Operand checks: Z_PARAM_STR → TypeError on object/enum

Repro

./script/docker-exec.sh -- php bin/vm.php test/repro-maintainer/issue_highlight_enum_typeerror.php

VM (wrong):

highlight_string: LogicException: highlight_string() expects string for argument 1 in this compiler build
highlight_file: LogicException: highlight_file() expects string for argument 1 in this compiler build
show_source: LogicException: highlight_file() expects string for argument 1 in this compiler build

Zend PHP 8.2+:

TypeError: highlight_string(): Argument #1 ($string) must be of type string, E given

Expected

All three builtins use VmString::coerceStringBuiltinArg() / EnumCaseSupport::isEnumCaseVariable() guard → TypeError message matching Zend naming ($string / $filename).

Implementation hints (PHP-in-PHP)

• ext/standard/highlight_string.php, highlight_file.php, show_source.php — replace LogicException type checks with VmString::coerceStringBuiltinArg() (same pattern as chr(), str_contains())
• JIT: when enabled (Stdlib: highlight_string/highlight_file/show_source — JIT/AOT lowering (phase 2 of #3164) #4366), mirror in lowering; today VM-only is acceptable if matrix notes VM path
• Compliance: test/compliance/cases/stdlib/highlight_enum_typeerror.phpt

Verification

./script/docker-exec.sh -- php bin/vm.php test/repro-maintainer/issue_highlight_enum_typeerror.php
./script/ci-fast.sh --filter 'highlight_enum'

Related: bootstrap native tokenizer #4824, JIT phase 2 #4366 — this issue is operand typing only.

[PurHur]

claim: PHP Compiler STD Lib — starting this run

[PurHur]

Merged via #6498

Verification (VM, php-src-strict):

• `php bin/vm.php test/repro-maintainer/issue_highlight_enum_typeerror.php` — all three builtins throw catchable `TypeError` with Zend message shape (`$string` / `$filename`, enum name `E`).
• `./vendor/bin/phpunit --filter highlight_enum test/compliance/` — green.
• Existing `highlight_string.phpt` smoke still passes.

Highlight builtins remain VM-only (#3164); operand typing fix is in `ext/standard/highlight_*.php` via `VmString::coerceStringBuiltinArg()`.