Stdlib: random_bytes() — enum case length operand must TypeError not silent coerce (php-src-strict)

[PurHur]

Category

stdlib (php-src-strict)

Problem

random_bytes() accepts backed enum case operands and coerces via the backing integer. Zend/php-src rejects enum cases with TypeError (ext/standard/random.c / Z_PARAM_LONG).

This is distinct from #4626 (numeric-string + LogicException vs TypeError for arrays); enum cases are a separate guard path via EnumCaseSupport / VmString::coerceStringBuiltinArg() patterns (#5780).

php-src reference

• php/php-src ext/standard/random.c — PHP_FUNCTION(random_bytes)
• php/php-src Zend/zend_API.c — Z_PARAM_LONG rejects objects/enums

Repro (failure today)

<?php
enum E: int { case A = 1; }
try {
    random_bytes(E::A);
    echo "accepted\n";
} catch (TypeError $e) {
    echo "TypeError\n";
}

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php repro_random_bytes_enum.php
php bin/vm.php repro_random_bytes_enum.php
'

Runtime	Output
Zend PHP 8.x	TypeError
bin/vm.php	accepted (silent coerce to length 1)

Scope (this repo)

Module	Path
VM	ext/standard/random_bytes.php — reject TYPE_ENUM_CASE before int coercion
Shared	lib/VM/EnumCaseSupport.php, lib/VM/VmString.php guards
JIT/AOT	ext/standard/JitRandomBytes.php — mirror VM TypeError
Tests	test/compliance/cases/stdlib/random_bytes_enum_typeerror.phpt

PHP-in-PHP: no new C in runtime/; reuse existing JitStringBuiltinArg / enum-case probes.

Done when

• Repro prints TypeError on VM/JIT/AOT (not accepted)
• Integer and numeric-string lengths still work (Stdlib: random_bytes() — TypeError + numeric-string length parity (ext/standard/random.c) #4626)
• ./script/ci-fast.sh --filter random_bytes_enum green

Verification

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter random_bytes_enum'

Related

• Stdlib: random_bytes() — TypeError + numeric-string length parity (ext/standard/random.c) #4626 numeric-string / array TypeError parity
• Stdlib: hash()/hash_hmac()/md5()/sha1()/crc32() — enum case operands must TypeError (ext/hash, ext/standard) #5780 hash/md5 enum strict batch
• North star: Epic: Self-host critical path — compiler compiles itself (M3→M5) #1492

[PurHur]

claim: worker-lane-B — starting this run

[PurHur]

Merged via #7611.

Verification

• Repro: php bin/vm.php test/repro/random_bytes_enum.php → random_bytes(): Argument #1 ($length) must be of type int, E given
• Tests: vendor/bin/phpunit --filter random_bytes_enum → OK (2 tests, VM + JIT)

PHP path: ext/standard/random_bytes.php, ext/standard/JitRandomBytesArg.php (no C runtime changes).