Stdlib: random_bytes() — TypeError + numeric-string length parity (ext/standard/random.c)

[PurHur]

Category

stdlib

Problem

random_bytes() exists on VM/JIT/AOT for integer lengths, but argument validation does not match Zend:

• Non-int/non-numeric-string operands raise LogicException (random_bytes() only supports integers in this compiler build) instead of TypeError.
• Numeric strings like "16" are rejected; Zend coerces via zend_parse_parameters long handling.
• Negative/zero lengths should follow Zend (ValueError / TypeError per php-src version).

php-src reference

• ext/standard/random.c — PHP_FUNCTION(random_bytes)
• ext/standard/basic_functions.stub.php — signature + errors

Repro (failure today)

<?php
declare(strict_types=1);

// happy path (works today)
echo strlen(random_bytes(8)), "\n";

// numeric string — Zend accepts
try {
    echo strlen(random_bytes('16')), "\n";
} catch (Throwable $e) {
    echo 'numeric-string:', get_class($e), ':', $e->getMessage(), "\n";
}

// invalid type — Zend TypeError
try {
    random_bytes([]);
} catch (Throwable $e) {
    echo 'array:', get_class($e), "\n";
}

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php repro_random_bytes_type.php
php bin/vm.php repro_random_bytes_type.php
php bin/jit.php repro_random_bytes_type.php
'

Call	Zend PHP 8.x	This compiler
random_bytes(8)	8 byte string	OK
random_bytes('16')	16-byte string	LogicException
random_bytes([])	TypeError	LogicException

Scope (this repo)

Module	Path
VM	ext/standard/random_bytes.php, ext/standard/VmString.php
JIT	ext/standard/JitRandomBytes.php (or inline in random_bytes::call)
Shared coercion	reuse numeric-string helpers from #4176 pattern
Tests	test/compliance/cases/stdlib/random_bytes_type.phpt, random_bytes_jit_type.phpt

Done when

• random_bytes('16') returns 16 bytes on VM/JIT/AOT
• Non-stringable/non-numeric operand → TypeError (Zend message subset)
• Invalid length (negative) → ValueError like Zend
• Existing random_bytes*.phpt still green
• ./script/ci-fast.sh --filter random_bytes green

Verification

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter random_bytes'

Related

• Stdlib: Random\Randomizer — PHP 8.2 ext/random OOP API (ext/random parity) #3722 Random\Randomizer OOP API (separate ext/random surface)
• CSPRNG used by Stdlib: ext/sodium — libsodium crypto API (ext/sodium parity) #3438 sodium stubs

[PurHur]

claim: PHP Compiler STD Lib — starting this run

[PurHur]

Merged via #7627.

VM/JIT parity: random_bytes('16') → 16 bytes; random_bytes([]) → TypeError (not LogicException); enum cases still TypeError (#6160); zero/negative → ValueError.

Implementation: VM uses VmMath::parseIntBuiltinArg(); JIT delegates to JitSleep::zParamLong() (php-src ext/standard/random.c Z_PARAM_LONG).

Verification:
```bash
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter random_bytes_type && vendor/bin/phpunit --filter random_bytes_enum && vendor/bin/phpunit --filter RandomBytesTypeJitCompileTest'
```
All green (4 + 2 + 2 tests).

AOT execute for random_bytes() remains pre-broken on master (LLVM verify); compile-only lowering guarded by RandomBytesTypeJitCompileTest.