Stdlib: number_format() — enum case operand must TypeError not silent coerce (ext/standard/number_format.c, phase 2 of #4163)

[PurHur]

Category

stdlib · php-src-strict

Problem

#4163 tracks number_format() rejecting array operands. Enum case operands are a separate gap: VM accepts backed enum cases (coercing or formatting via backing) while Zend throws TypeError because $num must be int|float, not an enum object.

php-src reference

• php/php-src ext/standard/number_format.c — php_number_format() Z_PARAM_NUMBER / float-only $num

PHP implementation target: ext/standard/number_format.php, ext/standard/JitNumberFormat.php — reject TYPE_ENUM_CASE before numeric coercion (same guard pattern as #5613 math batch).

Repro

test/repro-maintainer/parity_number_format_enum_operand.php:

docker info >/dev/null
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php test/repro-maintainer/parity_number_format_enum_operand.php
php bin/vm.php test/repro-maintainer/parity_number_format_enum_operand.php'

Runtime	Output
Zend PHP 8.2	TypeError: number_format(): Argument #1 ($num) must be of type float, E given
bin/vm.php	number_format: NO_ERROR (silent wrong path)

Done when

• Enum case $num throws TypeError on VM/JIT/AOT
• Valid int/float formatting unchanged
• Array operand still covered by Stdlib: number_format() — TypeError when $num is not int/float (ext/standard/number_format.c parity) #4163 separately
• Compliance PHPT: test/compliance/cases/stdlib/number_format_enum_type_error.phpt

Related

• Stdlib: number_format() — TypeError when $num is not int/float (ext/standard/number_format.c parity) #4163 — array $num TypeError
• Stdlib: math builtins (ceil/round/floor/abs/…) must TypeError on enum case operands (ext/standard/math.c) #5613 — ceil/round/floor/abs enum operand batch (math.c; distinct from number_format.c)

[PurHur]

claim: PHP Compiler STD Lib — starting this run

[PurHur]

Merged via #7925.

Fix: number_format() argument #1 enum case operands now throw TypeError: number_format(): Argument #1 ($num) must be of type float, E given on VM, JIT, and AOT (php-src-strict).

Verification:

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter number_format_enum'
# OK (4 tests, 4 assertions)

php-src: ext/standard/number_format.c. PHP impl: ext/standard/VmNumberFormat.php, ext/standard/JitNumberFormat.php (delegates to JitFdiv::lowerSingleOperand).