Stdlib: number_format() — TypeError when $num is not int/float (ext/standard/number_format.c parity)

[PurHur]

Category

stdlib

Problem

number_format() argument #1 must be int|float in PHP 8+. Passing an array must throw TypeError. This compiler fails to validate and may proceed with undefined behavior instead of matching Zend.

php-src reference

• php/php-src ext/standard/number_format.c — php_number_format() Z_PARAM_NUMBER / type checks

Repro

<?php
try {
    number_format(['x']);
} catch (Throwable $e) {
    echo get_class($e), ': ', $e->getMessage(), "\n";
}
// Zend: TypeError: number_format(): Argument #1 ($num) must be of type float, array given
// vm.php today: no TypeError (silent/wrong path)

./script/docker-exec.sh -- bash -lc '
  php -r "try { number_format([\"x\"]); } catch (Throwable \$e) { echo get_class(\$e),\": \",\$e->getMessage(),PHP_EOL; }"
  php bin/vm.php -r "try { number_format([\"x\"]); } catch (Throwable \$e) { echo get_class(\$e),\": \",\$e->getMessage(),PHP_EOL; }"
'

Scope

Area	Files
VM	ext/standard/number_format.php
JIT/AOT	ext/standard/JitNumberFormat.php
Tests	test/compliance/cases/stdlib/number_format_type_error.phpt

Done when

• Repro throws TypeError on VM/JIT/AOT
• Numeric-string $num behavior remains covered by Stdlib: number_format() — decimals argument must accept numeric strings (ext/standard/number_format.c) #4148 separately
• Valid float formatting PHPTs still pass

[PurHur]

claim: worker-lane-c — starting this run

[PurHur]

Unclaiming: VM repro already passes on master — number_format(['x']) throws TypeError: number_format(): Argument #1 ($num) must be of type float, array given. Recommend closing.

[PurHur]

claim: cursor-agent-lane-c — continuing worker-lane-c run (number_format TypeError parity)

[PurHur]

Merged via #18723.

Verification: VM/JIT repro for number_format(['x']) prints TypeError: number_format(): Argument #1 ($num) must be of type float, array given (matches Zend). Added compliance guards number_format_type_error.phpt + _jit.phpt; ./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter number_format_type_error' → OK (4 tests).