Repository navigation
Stdlib: extract() with enum case array keys must TypeError (ext/standard/basic_functions.c) #5756
Description
Category
stdlib
Problem
extract() must reject arrays whose keys are enum case objects.
Zend throws TypeError: Illegal offset type. Today, the VM appears to accept enum case keys and proceeds, which is incorrect and can import variables under unpredictable names.
This is a php-src-strict parity requirement.
php-src reference
ext/standard/basic_functions.c—PHP_FUNCTION(extract)key validation (zend_hash_*+ offset type rules)
Repro
Save as test/repro-maintainer/parity_extract_enum_keys.php:
<?php
enum E { case A; }
try {
extract([E::A => 1]);
echo "ok\n";
} catch (Throwable $e) {
echo $e::class, ': ', $e->getMessage(), "\n";
}Run:
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php test/repro-maintainer/parity_extract_enum_keys.php
php bin/vm.php test/repro-maintainer/parity_extract_enum_keys.php
'Expected (Zend):
TypeError: Illegal offset type
Observed (this compiler today):
- Prints
ok.
Scope (this repo)
ext/standard/extract.php(or builtin lowering) — validate key types before symbol table writeslib/VM/— ensure hash iteration surfaces enum case keys as illegal offsets consistently (do not coerce to backing scalar)- Add compliance test:
test/compliance/cases/stdlib/extract_enum_keys.phpt
Done when
- VM throws
TypeError: Illegal offset typefor enum case keys - Other illegal offset key types behave like Zend (objects/resources) (may be follow-up)
-
./script/ci-fast.sh --filter extract_enum_keysis green
Links
- Related: Language: enum case as array offset — write/read must TypeError not coerce to backing (zend_hash.c) #5753 (parse_str / enum keys), php-in-php: array_intersect() enum keys — delete C fast-path, VM Error parity from ext/standard/VmArray.php #5927 (array_intersect enum keys)
- North star: Epic: Self-host critical path — compiler compiles itself (M3→M5) #1492
Activity
PurHur commentedon Jun 9, 2026
claim: PHP Compiler STD Lib — starting this run
PurHur commentedon Jun 9, 2026
Unclaiming: extract([E::A => 1]) already throws TypeError on master before extract() runs (enum array literal guard from #5753). VM/JIT repro on test/repro-maintainer/parity_extract_enum_keys.php matches Zend. Recommend closing as duplicate unless repro differs (e.g. array reaching extract via non-literal path).
PurHur commentedon Jun 16, 2026
unclaim: stale — claim from 2026-06-09, no open PR, no activity >7d (maintainer triage 2026-06-16).
PurHur commentedon Jul 7, 2026
claim: cursor-agent-lane-c — starting this run
PurHur commentedon Jul 7, 2026
claim released: repro throws at array literal construction (Illegal offset type), not extract() — behavior matches Zend; issue stale.
PurHur commentedon Jul 16, 2026
unclaim: stale claim (>7 days, no open PR). Returning to
implementation-readypool for the next worker.PurHur commentedon Jul 18, 2026
claim: worker-lane-c — starting this run
Trust (this workspace):
php script/bootstrap-inventory.php --check→OK 5596/5596./script/release-readiness.sh --json→user_release_ready: yes(inventory, spine, north-star5-fast, vm-driver-probe ok)Pre-claim repro: both Zend and VM throw
TypeError: Illegal offset typeforextract([E::A => 1])and for$a[E::A]=1(non-literal). Will add the missingextract_enum_keyscompliance guard and close.Stdlib: guard extract() enum case keys with Illegal offset TypeError (#…
PurHur commentedon Jul 18, 2026
Merged via #20454
Verification
TypeError: Illegal offset typeforextract([E::A => 1])and$a[E::A]=1phpunit --filter extract_enum_keys→ OK (2 tests)Parity already held on master (array-key illegal offset); compliance + maintainer repro now guard #5756.