Stdlib: strtok() — TypeError for non-string operands (ext/standard/string.c parity, phase 2 of #3201)

[PurHur]

Category

stdlib

Problem

#3201 (closed) registered strtok() with continuation state (ext/standard/strtok.php, VmString::strtok). Invalid operand types still throw LogicException instead of Zend TypeError, and JIT must not segfault on bad types.

Same pattern as #4551–#4581 string TypeError sweep.

php-src reference

• php/php-src ext/standard/string.c — PHP_FUNCTION(strtok)
• php/php-src ext/standard/basic_functions.stub.php — (string $string, ?string $token = null)

Repro

<?php
foreach ([[123, ','], [ 'a,b,c', 456 ]] as [$s, $tok]) {
    try {
        strtok($s, $tok);
    } catch (Throwable $e) {
        echo get_class($e), ': ', substr($e->getMessage(), 0, 60), "...\n";
    }
}

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php repro.php'
php repro.php

Runtime	Result
Zend	TypeError for argument #1 and #2 with must be of type string
VM today	LogicException: strtok() argument #N must be a string in this compiler build

Happy path unchanged:

<?php
$s = 'a,b,c';
echo strtok($s, ','), ' ', strtok(','), ' ', strtok(','), "\n";
// a b c

Scope (this repo)

Layer	Path
VM	ext/standard/strtok.php, ext/standard/VmString.php
JIT	ext/standard/JitStrtok.php / StringStrtok — TypeError + no segfault
Tests	test/compliance/cases/stdlib/strtok_type_error.phpt

Done when

• TypeError repro matches Zend messages on VM
• JIT repro: bad types → TypeError; good types → a b c line
• ./script/ci-fast.sh --filter strtok_type green

Related

• Stdlib: strtok() — tokenize strings (ext/standard/string.c parity) #3201 (closed) — initial strtok
• Stdlib: str_shuffle() — TypeError for non-string operands (ext/standard/string.c parity) #4551 str_shuffle() TypeError template

[PurHur]

claim: PHP Runtime → PHP — starting this run (#4587 strtok TypeError VM/JIT)

[PurHur]

Merged via PR #8300.

Change: PHP-only — ext/standard/strtok.php now uses VmString::coerceNullableStringBuiltinArg() / coerceStringBuiltinArg() on VM and JitStringBuiltinArg::lower() on JIT/AOT. Invalid operands (array/object/enum) raise TypeError matching php-src instead of LogicException; no runtime/*.c changes.

Verification:

• php bin/vm.php test/repro/maintainer_strtok_typeerror.php → TypeError + happy path a b c
• php bin/jit.php test/repro/maintainer_strtok_typeerror.php → same, exit 0 (no segfault)
• vendor/bin/phpunit --filter strtok_type → OK (4 tests)
• vendor/bin/phpunit --filter strtok → OK (11 tests)