Repository navigation
Language: PROFILE=8.4 final plain property compile accepted — Zend isFinal/override fatal (re-#24992, Zend/zend_compile.c) #29762
Description
Category
Language · php-src-strict · PHP 8.4 final plain properties
Problem
With PHP_COMPILER_PROFILE=8.4, the compiler accepts public final string $x and reports ReflectionProperty::isFinal() === false. Child classes can override the property without error. Zend 8.4 rejects redeclaration and exposes isFinal() === true.
#24992 was closed but probed 2026-08-10 the VM path is still wrong.
| Repro | Zend 8.4 (reference) | VM PROFILE=8.4 |
|---|---|---|
public final string $x in class A |
ReflectionProperty::isFinal() true |
isFinal() false |
Child redeclares $x |
compile/runtime fatal | override_ok (no error) |
php-src reference
- php/php-src
Zend/zend_compile.c— final property modifier - php/php-src
Zend/zend_inheritance.c— override rules - php/php-src
ext/reflection/php_reflection.c—ReflectionProperty::isFinal()
PHP implementation target
lib/compile-time property flags +ext/reflectionPHP port — enforce final plain properties on PROFILE≥8.4; PHP-in-PHP lowering
Repro
./script/docker-exec.sh -- bash -lc 'PHP_COMPILER_PROFILE=8.4 php bin/vm.php test/repro/maintainer_gap_final_property_re24992.php'
# expect: ok (isFinal true, child override fatal)
# actual: fail: ReflectionProperty::isFinal() falseDone when
-
finalon plain typed properties parsed and enforced on PROFILE=8.4 -
ReflectionProperty::isFinal()matches Zend - Child override throws Zend-shaped fatal
- Compliance
.phptundertest/compliance/cases/language/ - php-src-strict; no php-compiler-strict shortcut
Activity
PurHur commentedon Aug 10, 2026
claim: Worker lane C (implementer) — starting this run
Prior claim #29768 closed as not-a-bug (Zend matches VM read-only message; re-#26006).
Gates: north-star5-fast OK; spine-coverage RED on TypedParamCoerce (#29781 lane A); open PRs none.
Lane C: #29762 % 3 == 2.
PurHur commentedon Aug 10, 2026
Resolution: already fixed on master (re-#24992)
Probed this run under
PHP_COMPILER_PROFILE=8.4— behavior already matches Zend 8.4.VM (host)
Same-file child redeclaration and ctor-declared
public final string $xalso compile-fatal withCannot override final property A::$x(exit 255). Related repros (maintainer_gap_final_plain_property_84.php,issue_28393_final_plain_isfinal.php,reflection_property_is_final_plain.php) printisFinal=1.Zend 8.4 reference
Existing guards
test/compliance/cases/language/final_plain_property_child_override_84.phpttest/compliance/cases/language/final_plain_property_reflection_84.phpttest/repro/maintainer_gap_final_property_profile84.php(from Language: final plain properties still accepted on reference profile — Zend compile fatal; PROFILE=8.4 isFinal/override broken (re-#24686, Zend/zend_compile.c) #24992 / Language: reject eval override of final static properties (#24992) #25007)Filed Done-when is already satisfied; issue repro path
maintainer_gap_final_property_re24992.phpwas never committed — usemaintainer_gap_final_property_profile84.phpinstead.Closing as already fixed. No code change / PR.
PurHur commentedon Aug 10, 2026
Already fixed on master (merged #25007 / #24992). PROFILE=8.4 VM matches Zend: isFinal=1 + child override Fatal. See verification comment.