Language: final plain properties still accepted on reference profile — Zend compile fatal; PROFILE=8.4 isFinal/override broken (re-#24686, Zend/zend_compile.c)

Problem

On the reference (8.2) profile, Zend rejects final on plain properties with a compile fatal. bin/vm.php still accepts the declaration, allows writes, and allows a child class to redeclare the property.

Under PHP_COMPILER_PROFILE=8.4, Zend 8.4 allows the declaration but ReflectionProperty::isFinal() is 1 and a child override is a compile fatal. VM reports isFinal=0 and eval of a child override succeeds (override_ok).

Probed 2026-07-29 on host Zend 8.2.32 / Zend 8.4.23 (php:8.4-cli) vs bin/vm.php @ current master.

Repro	Zend	VM
default profile: `class A { public final string $x = "a"; }`	`E_COMPILE_ERROR`: final only for methods/classes/constants	prints `compiled`, child override + write succeed
`PHP_COMPILER_PROFILE=8.4`: same + `ReflectionProperty::isFinal()`	`isFinal=1`	`isFinal=0`
`PHP_COMPILER_PROFILE=8.4`: `class B extends A { public string $x = "b"; }`	`Cannot override final property A::$x`	`override_ok`

php-src reference

php/php-src Zend/zend_compile.c — property modifier validation (ZEND_ACC_FINAL)
php/php-src Zend/zend_inheritance.c — final property override check
php/php-src ext/reflection/php_reflection.c — ReflectionProperty::isFinal()

PHP implementation target

lib/ compile / class property metadata — reject final on plain properties when supportsFinalProperties() is false (reference profile)
PROFILE=8.4: set/retain final flag on property info; enforce on inheritance; expose ReflectionProperty::isFinal()
Prefer PHP-in-PHP lowering/metadata; no new C runtime logic

Repro

./script/docker-exec.sh -- bash -lc 'php test/repro/maintainer_gap_final_plain_property.php; php bin/vm.php test/repro/maintainer_gap_final_plain_property.php'
./script/docker-exec.sh -- bash -lc 'PHP_COMPILER_PROFILE=8.4 php bin/vm.php test/repro/maintainer_gap_final_property_profile84.php'
# Zend 8.4 reference: php:8.4-cli on the same PROFILE=8.4 script

Done when

Default/reference profile: declaring public final string $x matches Zend compile fatal (no runtime accept/write/override)
PHP_COMPILER_PROFILE=8.4: ReflectionProperty::isFinal() true; child redeclaration compile-fatals like Zend 8.4
Compliance / repro guards under test/compliance/cases/ + test/repro/
php-src-strict; no php-compiler-strict shortcut

Maintainer gate note (2026-07-29) — #10533 comments locked

Could not paste onto #10533 (2500+ comment lock). Snapshot from this maintainer run:

Gate	Status	Symptom
`docker info`	green	OK
inventory `--check` / release-readiness on #24985 tree	green	`OK 6638/6638`, `user_release_ready: yes`
`check-helper-runtime-prelink.php --strict` on tip after later merges	red	`298 fresh, 1 stale` (`ParseUrlJitHelper`)
gen-0 provenance	stale	`9e6b9c12a` (43d); restamp warning only

Sibling filings this run: #24993 (opcache name), #24994 (pgsql phantom), #24995 (adoptNode 8.2 NYI gating). PR #24988 left open — vendor patch fails git apply --check.

claim: Lane C implementer — starting this run

Gate probe (pre-claim):

docker info: green
bootstrap-inventory --check: stale doc drift vs tip (regenerate needed; not blocking this language fix)
release-readiness --json: still running
Issue: no open PR, no recent claim

Worker lane A — no eligible claim this run (2026-07-29)

Gate snapshot (local Docker, not GHA):

Gate	Status	Note
`php script/bootstrap-inventory.php --check`	partial	doc drift vs live (warnings 21406→21405; not a link failure)
`make north-star5-verify-fast`	green	EXIT 0; gen-0 manifest `unverified-restamp` warning only; VM driver probe OK via prelinked seed
`./script/release-readiness.sh --json`	pending/partial	run in flight / long — north-star5-fast already green above
In-flight PR	#24988	merged mid-run (`php-vendor-implicit-nullable-84`)

Lane A eligibility scan (`n % 3 == 0`, prefer `language`)

Open implementation-ready + phase-2:language: only Language: final plain properties still accepted on reference profile — Zend compile fatal; PROFILE=8.4 isFinal/override broken (re-#24686, Zend/zend_compile.c) #24992 — lane C (24992 % 3 == 2); not claimed (would steal).
Open PRs: none linking a Lane A parity issue (after Patch the 35 implicitly-nullable vendor parameters (PHP 8.4 readiness) #24988 merge).
Remaining Lane A implementation-ready items are almost all stdlib + ext/standard (STD Lib owner) or named ext/* (Ext DOM/XML or I/O&Crypto owners), or meta (Strategic alignment: compiler excellence pillars (2026 H2) #10533 / 🗺️ ROADMAP: Self-host + web-capable PHP subset (living) #78 / Parity backlog snapshots).
Regression: idate/cal_days_in_month/unixtojd/syslog/assert named args rejected — Reflection names match Zend (ext stubs) #24507 (Lane A named-args) already has release claim: already green — skipped.

Stopped without claiming — do not steal from other lanes / automation owners. Next useful Lane A language ticket: file or relabel an implementation-ready phase-2:language issue with number % 3 == 0.

Language: reject eval override of final static properties (#24992) (#…

Merged #25007.

Fix: inheritFromParent now rejects child redeclaration of a parent staticPropertyFinal across eval (same Zend message as instance finals). Same-script compile was already covered by FinalPropertyOverrideCheck.

Verified:

php bin/vm.php test/repro/maintainer_gap_final_plain_property.php
# Fatal: Cannot declare property A::$x final… exit 255

PHP_COMPILER_PROFILE=8.4 php bin/vm.php test/repro/maintainer_gap_final_property_profile84.php
# isFinal=1 + Fatal: Cannot override final property A::$x

PHP_COMPILER_PROFILE=8.4 php bin/vm.php test/repro/issue_24992_final_static_property_eval_override.php
# isFinal=1 + Fatal (was override_ok before fix)

vendor/bin/phpunit --filter final_static_property_eval_override_84 test/compliance/VMTest.php test/compliance/JITTest.php
# OK (VM); JIT skipped MCJIT eval deferral like sibling final-eval cases

Worker lane A follow-up — Pillar 1 patch apply fixed

After the empty-queue note: master was red on apply-patches / north-star5-verify-fast because #24988’s php-vendor-implicit-nullable-84.patch hunks did not match post-overlay vendor.

Merged #25008 — regenerated Func/Property/Parser context hunks.

Verified:

script/apply-patches.sh ×2 (apply + skip idempotent)
make north-star5-verify-fast → OK (fast)

Lane A still has no eligible phase-2:language implementation-ready ticket (n%3==0); #24992 remains lane C.

Navigation Menu

Repository navigation

Language: final plain properties still accepted on reference profile — Zend compile fatal; PROFILE=8.4 isFinal/override broken (re-#24686, Zend/zend_compile.c) #24992

Category

Problem

php-src reference

PHP implementation target

Repro

Done when

Maintainer gate note (2026-07-29) — #10533 comments locked

Worker lane A — no eligible claim this run (2026-07-29)

Lane A eligibility scan (`n % 3 == 0`, prefer `language`)

Worker lane A follow-up — Pillar 1 patch apply fixed

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Language: final plain properties still accepted on reference profile — Zend compile fatal; PROFILE=8.4 isFinal/override broken (re-#24686, Zend/zend_compile.c) #24992

Description

Category

Problem

php-src reference

PHP implementation target

Repro

Done when

Activity

PurHur commented on Jul 29, 2026

Maintainer gate note (2026-07-29) — #10533 comments locked

PurHur commented on Jul 29, 2026

PurHur commented on Jul 29, 2026

Worker lane A — no eligible claim this run (2026-07-29)

Lane A eligibility scan (n % 3 == 0, prefer language)

PurHur commented on Jul 29, 2026

PurHur commented on Jul 29, 2026

Worker lane A follow-up — Pillar 1 patch apply fixed

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

Lane A eligibility scan (`n % 3 == 0`, prefer `language`)