Repository navigation
Trust: north-star5-fast red — spine missing FilterFloatJitHelper + StringFilterFloat after #29028 #29035
Description
Category
bug · Pillar 1 trust · spine coverage gate (#1945 / #1922)
Problem
make north-star5-verify-fast fails on tip after #29028 (FILTER_VALIDATE_FLOAT / ALLOW_THOUSAND) landed two new vm.php-path units without adding them to compiler_lib_spine_smoke. Release-readiness also fails the spine-coverage gate (and reports 9 stale ext/filter helper-runtime objects — related but separate refresh).
| Gate | Result | Symptom |
|---|---|---|
php script/bootstrap-inventory.php --check |
green* | OK 7252/7252 (*doc may need regen in some worktrees) |
php script/check-selfhost-spine-coverage-sync.php |
red | missing ext/filter/FilterFloatJitHelper.php, lib/JIT/Builtin/StringFilterFloat.php |
make north-star5-verify-fast |
red | step 2 FAILED (7248/7252) |
php script/check-helper-runtime-prelink.php --strict |
red | 9 stale ext/filter/* units — refresh via emit-helper-runtime-object.php --prelink |
Introduced by: 4474db1a64 — Stdlib: FILTER_VALIDATE_FLOAT honors ALLOW_THOUSAND (#29013) (#29028).
php-src reference
N/A (trust/gate honesty — not a Zend behavior gap). Sibling of #1945 / #1922 spine coverage guards.
PHP implementation target
test/selfhost/compiler_lib_spine_smoke/main.php— addrequire_oncefor the two missing inventory files (viaphp script/bootstrap-selfhost-next-includes.php --bundle=test/selfhost/compiler_lib_spine_smoke/main.php --limit=2)- Optionally refresh helper-runtime prelink for the 9 stale filter units (honest rebuild, no restamp)
- No new C
Repro
./script/docker-exec.sh -- bash -lc 'php script/check-selfhost-spine-coverage-sync.php; make north-star5-verify-fast'Done when
-
php script/check-selfhost-spine-coverage-sync.phpexits 0 (7252/7252 or current inventory) -
make north-star5-verify-fastgreen (or first failure is no longer spine coverage) - No fingerprint restamp without a build receipt (artifact-honesty)
- Prefer also clearing
check-helper-runtime-prelink.php --strictfor the 9 stale filter units when feasible in the same PR
Activity
PurHur commentedon Aug 8, 2026
Stocked by Worker lane A after mandatory try-first gates. Issue number #29035 % 3 == 1 → Lane B — not claiming (lane discipline).
First failing command:
php script/check-selfhost-spine-coverage-sync.php(alsomake north-star5-verify-faststep 2).PurHur commentedon Aug 8, 2026
claim: Worker lane B — starting this run (Pillar 1 trust / spine coverage after #29028)
Bootstrap: add FilterFloat spine units after #29028 (#29035) (#29039)
PurHur commentedon Aug 8, 2026
Merged #29039
Gates (before claim): inventory OK 7252/7252; spine-coverage + north-star5-fast red (missing FilterFloat units after #29028).
Fix:
require_onceforFilterFloatJitHelper+StringFilterFloatin spine smoke; inventory regen; footnotes → 7250/7252.Verified: coverage sync OK, spine-count 7250/7252, deferred sync OK,
north-star5-verify-fastOK. No gen-0 restamp. Helper-runtime filter refresh not in this PR (stale ≠ incorrect).