Skip to content

Self-host M2: Close compiler_lib_spine_smoke gap (589→593 inventory units) #1922

Description

@PurHur

Problem

M2 spine smoke links 595 of 603 bin/vm.php inventory files (#1872 SSOT via php script/bootstrap-spine-count.php and grep -c '^require_once' test/selfhost/compiler_lib_spine_smoke/main.php). Phase A reports 0 source blockers — the remaining 8 files are a coordination gap, not unknown syntax.

Without a focused tracker, contributors grep #1419 (closed umbrella) or #1492 epic instead of a finish-line checklist.

Note (batch 92): Older comments cited 589/593; inventory grew to 603 files — always trust bootstrap-spine-count.php on master.

Goal

test/selfhost/compiler_lib_spine_smoke/main.php includes all 603 inventory units; these gates stay green:

php script/bootstrap-inventory.php --check          # 603 files, 0 blockers
php script/bootstrap-spine-count.php                # 603/603
php bin/compile.php -l test/selfhost/compiler_lib_spine_smoke/main.php
make bootstrap-selfhost-lib-spine-smoke             # native link
BOOTSTRAP_LIB_SPINE_VM_SMOKE=1 make bootstrap-selfhost-lib-spine-vm-smoke

Implementation hints

Step Command / file Notes
Diff php script/bootstrap-inventory.php vs spine require_once list Identify 8 missing paths
Batch PRs One file or small group per PR Label m2-spine-unit; close on merge
Blockers lib/VM/HashTable.php, JIT builtins May need #1514-class runtime fixes before link
Count SSOT script/bootstrap-spine-count.php + script/check-selfhost-spine-count-sync.php Must read 603/603 after merge
Docs docs/self-host-target.md, docs/bootstrap-selfhost.md M2 table row 595/603

Inventory diff (run on master — refresh each batch)

docker run --rm -v "$(pwd):/compiler" -w /compiler php-compiler:22.04-dev \
  bash -lc 'php script/bootstrap-spine-count.php; php script/bootstrap-inventory.php --check'

Do not hard-code the 8 paths in this issue body — paste diff output into PR descriptions.

Acceptance criteria

Verification (local / Docker only)

make docker-build-22
docker run --rm -v "$(pwd):/compiler" -w /compiler php-compiler:22.04-dev \
  bash -lc 'php script/bootstrap-inventory.php --check && make bootstrap-selfhost-lib-spine-smoke'

No GitHub Actions.

Dependencies

Links

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions