Repository navigation
Regression: highlight_string/highlight_file HTML wire — Zend <code><span> + (re-#25419, ext/standard/basic_functions.c) #27827
Description
Category
bug · php-src-strict · highlight HTML wire · pillar 4
Problem
highlight_string() / highlight_file() / show_source() still emit a non-Zend HTML wire format. Zend 8.2 wraps with <code><span style="color: #000000">… and uses for spaces; this compiler emits a <pre><code style=…> wrapper and ordinary spaces (no ). Previously closed as #25419 / #25264 / #25063 / #24662 — still red on master (2026-08-05).
| Repro | Zend 8.2.32 | VM/JIT |
|---|---|---|
highlight_string('<?php echo 1;', true) starts with |
<code> |
<pre> |
contains |
yes | no |
contains <pre> |
no | yes |
php-src reference
- php/php-src
ext/standard/basic_functions.c—php_highlight - php/php-src
ext/standard/css.c/ highlight helpers
PHP implementation target
ext/standardhighlight PHP port — match Zend 8.2 outer<code><span>nesting, spacing, and newline placement around the outer span- Keep PROFILE=8.4+ wire identical to the active php-src line if it differs; gate only if php-src changed
- PHP-in-PHP; no new
runtime/*.c
Repro
./script/docker-exec.sh -- bash -lc '
cat > /tmp/hl.php <<'"'"'PHP'"'"'
<?php
$html = highlight_string("<?php echo 1;", true);
echo (str_starts_with($html, "<code>") ? "START_CODE" : (str_starts_with($html, "<pre>") ? "START_PRE" : "START_OTHER")), PHP_EOL;
echo (str_contains($html, " ") ? "HAS_NBSP" : "NO_NBSP"), PHP_EOL;
echo (str_contains($html, "<pre>") ? "HAS_PRE" : "NO_PRE"), PHP_EOL;
PHP
echo ZEND:; php /tmp/hl.php
echo VM:; php bin/vm.php /tmp/hl.php
echo JIT:; php bin/jit.php /tmp/hl.php
'Done when
- VM + JIT match Zend wrapper (
START_CODE,HAS_NBSP,NO_PRE) on the host reference profile -
highlight_file/show_sourcesame wire - Compliance
.phptasserts prefix/ (not only “contains php”); php-src-strict; no php-compiler-strict shortcut
Gate context (2026-08-05)
- inventory OK 7020/7020;
north-star5-fastred (gen-0 Self-host M5: bootstrap-inventory argv driver size floor — grow beyond 451KB stub #8713) — unrelated to highlight
Activity
PurHur commentedon Aug 8, 2026
claim: PHP Compiler STD Lib Advanced — batch (issues #27165, #27716, #27827)
Queued after #27165/#27716. Zend highlight HTML wire (
<code><span>+ , no<pre>).PurHur commentedon Aug 8, 2026
claim: PHP Compiler STD Lib Advanced — starting #27827 (batch #27165/#27716/#27827)
#27165 → #28951, #27716 → #28952 merged. Implementing Zend highlight HTML wire (
<code><span>+ , no<pre>).PurHur commentedon Aug 8, 2026
Already fixed on master — verified 2026-08-08 @
f9def272f9in Docker.Issue repro Zend /
bin/vm.php/bin/jit.phpall printSTART_CODE/HAS_NBSP/NO_PRE. Fullhighlight_string('<?php echo 1;', true)HTML is byte-identical Zend↔VM↔JIT.highlight_file/show_sourcesame wrapper (CODE NBSP NOPRE).Root cause landed earlier: #25063 / #25264 (
HighlightEngine::usesPreCodeWrapperwithholds<pre><code>on unset PROFILE so reference matches Zend 8.2).Closing — no further PR. Batch continues with a replacement stdlib item.