Repository navigation
Regression: highlight_string/highlight_file/show_source HTML wire still differs — Zend <code><span> + (re-#24662, ext/standard/basic_functions.c) #25063
Description
Category
Regression: · php-src-strict · highlight HTML wire format
Problem
highlight_string / highlight_file / show_source still do not match Zend’s HTML. Zend wraps with <code><span…> and uses for spaces; this compiler emits a <pre><code style=…> shell, omits , and uses different span nesting.
Probed 2026-07-29 (8a0cba472 vs host Zend 8.2.32), VM + JIT:
Check on highlight_string("<?php echo 1;", true) |
Zend 8.2+ | VM/JIT |
|---|---|---|
contains |
yes | no |
contains <pre> |
no | yes |
matches /<code><span/ |
yes | no |
#24662 / #24524 / #24288 / #23733 closed green earlier, but master is still red on this wire format (show_source matches the same wrong shell).
php-src reference
- php/php-src
ext/standard/basic_functions.c—PHP_FUNCTION(highlight_string)/highlight_file - php/php-src
ext/standard/url.c/ highlight helpers — Zend HTML emitter (php_highlight_*)
PHP implementation target
ext/standard/highlight path + anylib/VM/Builtin/*Highlight*/ JIT call mirror — emit Zend wire (<code><span…>, , no outer<pre>); no new C runtime logic
Repro
./script/docker-exec.sh -- bash -lc 'cat > /tmp/hl.php <<'"'"'PHP'"'"'
<?php
$z = highlight_string("<?php echo 1;", true);
echo "nbsp=" . (strpos($z, " ") !== false ? "1":"0") . "\n";
echo "pre=" . (strpos($z, "<pre>") !== false ? "1":"0") . "\n";
echo "code_span=" . (preg_match("/<code><span/", $z) ? "1":"0") . "\n";
PHP
php /tmp/hl.php; php bin/vm.php /tmp/hl.php; php bin/jit.php /tmp/hl.php'Done when
- VM + JIT
highlight_string($code, true)match Zend on / no<pre>//<code><span/ -
highlight_file+show_sourcesame wire - Compliance
.phptguard undertest/compliance/cases/(ortest/repro/) - php-src-strict; no php-compiler-strict shortcut
Activity
PurHur commentedon Jul 30, 2026
claim: PHP Compiler STD Lib Advanced — batch (issues #25063, #25097, #23785)
Hard stdlib cluster: highlight_string/file/show_source Zend HTML wire (#25063), next/prev/current on object HT (#25097), highlight Reflection names (#23785). Shipping sequential PRs; starting with #25063.
PurHur commentedon Jul 30, 2026
Investigating: default
CompilerVersion::VERSIONis8.4.0-dev, so highlight emits PHP 8.3+<pre><code>wire (#24874). Host Zend in the pinned image is 8.2.32 (<code><span>+ ).Under
PHP_COMPILER_PROFILE=8.2, VM already matches the #25063 shape checks (nbsp=1, pre=0, code_span=1). Confirming whether the issue wants (a) default profile to follow reference Zend 8.2 wire, or (b) docs/repro to use PROFILE=8.2 — colliding with closed #24874 if we flip the default.Stdlib: withhold highlight <pre><code> on reference profile (#25063) (#…
PurHur commentedon Jul 30, 2026
Merged via #25128
Verification: Zend/VM/JIT reference wire identical (
nbsp=1 pre=0 code_span=1); PROFILE=8.4 modern wire still green; compliance extracts +VmHighlightTest8/8.Batch next: #25097 (
next/prev/currenton object HT).