Skip to content

php-in-php: MathModf NestedJIT → JitVmHelperLink::ensureCompiled (#1492) #22519

Description

@PurHur

Category

php-in-php · runtime-shrink (#1492, peer #22495 Lcg / #22468 StreamSocketPairRuntime)

Problem

lib/JIT/Builtin/MathModf.php still hand-rolls NestedJitCompileScope::run + parseAndCompile + new JIT() for ModfJitHelper.php. Peer runtimes route helper compile through JitVmHelperLink::ensureCompiled for consistent user-script env clearing, insert-block restore, and helper-runtime cache.

php-src reference

PHP implementation target

  • lib/JIT/Builtin/MathModf.php — replace ensureJitHelperCompiled body with JitVmHelperLink::ensureCompiled + lookupCompiled; drop use PHPCompiler\JIT / NestedJitCompileScope
  • test/unit/ModfRuntimeShrinkTest.php — guard JitVmHelperLink::ensureCompiled, no hand-rolled NestedJitCompileScope::run / parseAndCompile / new JIT(

Repro

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit test/unit/ModfRuntimeShrinkTest.php'
make bootstrap-selfhost-vm-driver-execute-probe

Done when

  • MathModf uses JitVmHelperLink::ensureCompiled only for helper compile
  • Shrink unit test green
  • make bootstrap-selfhost-vm-driver-execute-probe green
  • PR body cites lines removed

Refs #1492, #15200, #22495, #22468

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:compilerCompiler / CFG / JITenhancementNew feature or requestimplementation-readySpec complete: repro, php-src ref, done-when — safe for workers to claimphase-0:FoundationPhase 0 – foundation & DevEx

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions