php-in-php: StreamSocketPairRuntime NestedJIT → JitVmHelperLink::ensureCompiled (#1492)

[PurHur]

Category

php-in-php · runtime-shrink (#1492, peer #22431 GzStreamRuntime / #22416 Bz2StreamRuntime)

Problem

lib/JIT/Builtin/StreamSocketPairRuntime.php still hand-rolls NestedJitCompileScope::run + parseAndCompile + new JIT() for StreamSocketPairJitHelper.php. Peer runtimes route helper compile through JitVmHelperLink::ensureCompiled for consistent user-script env clearing, insert-block restore, and helper-runtime cache.

Keep NestedJitCompileScope::isActive() early-return in implement() (skip bridge emission during nested helper compile) — only delete the hand-rolled compile body.

php-src reference

• php/php-src ext/standard/streamsfuncs.c — PHP_FUNCTION(stream_socket_pair) (semantics unchanged; compile-path only)

PHP implementation target

• lib/JIT/Builtin/StreamSocketPairRuntime.php — replace ensureJitHelperCompiled body with JitVmHelperLink::ensureCompiled; use lookupCompiled; drop unused use PHPCompiler\JIT
• test/unit/StreamSocketPairRuntimeShrinkTest.php — guard JitVmHelperLink::ensureCompiled, no hand-rolled NestedJitCompileScope::run / parseAndCompile / new JIT(

Repro

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit test/unit/StreamSocketPairRuntimeShrinkTest.php'
make bootstrap-selfhost-vm-driver-execute-probe

Done when

• StreamSocketPairRuntime uses JitVmHelperLink::ensureCompiled only for helper compile
• Shrink unit test green
• make bootstrap-selfhost-vm-driver-execute-probe green
• PR body cites lines removed

Refs #1492, #13710, #21082, #22431, #22416

[PurHur]

claim: PHP Runtime → PHP — starting this run

Preflight (this workspace, master @7d94ec67e):

• docker info OK
• php script/bootstrap-inventory.php --check — red (file-list drift: + lib/Ast/FinalPromotedPropertyRewriter.php; construct-flag drift in VmUnserializeFormat/VM/DateTimeSupport) — regenerate needed on master, not blocker for this NestedJIT link migration
• make bootstrap-selfhost-link in flight via ./script/docker-exec.sh (Zend gen-0 fallback after stale native driver fingerprint want 6e63bed4… / have d4c5f5aa…) — will note first verify outcome when finished
• Regression: bootstrap-selfhost-link LLVM Module verify — valueDelref/writeLong/icmp type mismatch (re-#22139) #22449 already claimed by another agent (skip); php-in-php: delete JitRename libc defer bridge — route user-script AOT through JitVmHelperLink + RenameJitHelper PHP (#1492) #19215 closed; next eligible NestedJIT→JitVmHelperLink candidate is StreamSocketPairRuntime

Implementing JitVmHelperLink::ensureCompiled migration (peer #22431).

[PurHur]

Merged via #22469

Verification

• vendor/bin/phpunit test/unit/StreamSocketPairRuntimeShrinkTest.php → OK (4 tests, 24 assertions) host + Docker
• make bootstrap-selfhost-vm-driver-execute-probe → OK

Shrink: hand-rolled NestedJIT compile body deleted; JitVmHelperLink::ensureCompiled only (diffstat −40/+20 on touched files).

Preflight note (master, not this PR): bootstrap-selfhost-link still red with #22449 IR type mismatch; user_release_ready: no (spine missing FinalPromotedPropertyRewriter.php).