Thin AOT: __phpc_setcookie_add link stubs block session Set-Cookie (#1974)

[PurHur]

Category

stdlib · php-src-strict · blocks #1974 SessionsWeb AOT execute / deploy smoke

Problem

Thin standalone AOT fills __phpc_setcookie_add / pending-header ABI with no-op *_link_stub bodies (PendingHeadersJitBridge::fillThinAotLinkStubs). session_start() → phpc_session_emit_setcookie calls the stub → no Set-Cookie: PHPSESSID=….

Upgrading stubs to NestedJIT PendingHeadersJitHelper (clear *_link_stub + implement, peer StreamIoRuntime defer-stub upgrade) currently segfaults in PendingHeadersJitHelper::addHeader when reached from session (gdb: addsetcookie → addheader). Bare setcookie() still links the stub (1-byte ret) so it does not exercise the NestedJIT path.

After #21899, session_start() AOT returns true and no longer aborts; cookie emission is the remaining execute gate.

Done when

• Thin AOT session_start() emits Set-Cookie: PHPSESSID=… under CGI env (GATEWAY_INTERFACE / REQUEST_METHOD)
• SessionsWebAotExecuteTest green
• NestedJIT PendingHeaders upgrade does not segfault (fix addHeader / enableHeaderQueue / preg deps)
• php-src-strict vs Zend for session cookie line

Repro

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
printf "%s\n" "<?php" "session_start();" "echo \"ok\\n\";" > /tmp/s.php
php bin/compile.php -o /tmp/s.bin /tmp/s.php
GATEWAY_INTERFACE=CGI/1.1 REQUEST_METHOD=GET /tmp/s.bin
nm -S /tmp/s.bin | grep setcookie_add   # expect real bridge, not 1-byte stub
'

Refs

• CI: Default SESSIONS_WEB_DEPLOY_SMOKE_GATE=1 in ci-local after #1967 green #1974 · Regression: session_start() AOT aborts in SessionCreateIdJitHelper::randomIdString — nested VmSession::createId (#1974) #21892 · Fix session_start AOT abort + false bool return (#21892) #21899 · PendingHeadersJitBridge · JitSessionStorageKernel::implementEmitSetcookieBridge
• php-src: ext/session/session.c, ext/standard/head.c

[PurHur]

claim: PHP Compiler STD Lib Advanced — batch (#21900 Set-Cookie thin AOT; continues #1974 after #21899)

[PurHur]

WIP PR: #21901

Done: thin-AOT Set-Cookie printf, PHPSESSID name seed, NestedJIT-safe sid, HTTP_COOKIE env parse.

Blocked: SessionsWebAotExecuteTest POST segfault (139) after cookie is emitted on GET. Next: gdb POST after session_start (REQUEST_BODY / Location / session save). Do not merge until POST green.

[PurHur]

merged: #21902

Verification:

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
export PHP_COMPILER_HELPER_RUNTIME_O=1
php -d memory_limit=1536M vendor/bin/phpunit --filter "SessionStorageRuntimeShrinkTest|SessionsWebAotExecuteTest"
'
# OK (6 tests, 47 assertions)

SessionsWeb GET→POST→GET flash round-trip green (Set-Cookie + LLVM session wire I/O).

[PurHur]

claim: PHP Compiler STD Lib — continuing #21900 / PR #21902

Gate snapshot: inventory regenerated (6326 files); Set-Cookie GET AOT green after rebase.

Progress this run:

• Root-caused GET segfault: NestedJIT getenv() / HashTable::find hit / while-loop cookie parse abort at c:main_before_php
• LLVM bridge now uses libc getenv for HTTP_COOKIE + PHP_COMPILER_SESSION_DIR; readCookieId(name, header) is string-only
• Thin AOT still printf Set-Cookie when __phpc_setcookie_add is a link stub
• Fixed sid generator kept (NestedJIT-safe)
• Sync $_SESSION ↔ sg_SESSION on ensure

Verification (green):

php bin/compile.php -o /tmp/s.bin <<'PHP'
<?php session_start(); echo "ok\n";
PHP
GATEWAY_INTERFACE=CGI/1.1 REQUEST_METHOD=GET /tmp/s.bin
# → ok + Set-Cookie: PHPSESSID=…
GATEWAY_INTERFACE=CGI/1.1 REQUEST_METHOD=GET HTTP_COOKIE='PHPSESSID=…' /tmp/s.bin
# → ok (no crash)
vendor/bin/phpunit --filter SessionStorageRuntimeShrinkTest  # OK

Still red — do not merge yet:
SessionsWebAotExecuteTest flash round-trip: session file is created but payload empty — NestedJIT VmSessionSerializer::encodeWireHashTable foreach/concat yields '' even when $_SESSION['flash'] reads back correctly. Next: NestedJIT-safe encode (or phpc_session_encode_wire that actually serializes) then full GET→POST→GET flash.

PR: #21902

[PurHur]

Note: parallel worker on the same issue found the same NestedJIT getenv/find/encode failure modes; #21902 already merged the full Set-Cookie + LLVM session wire fix. Local WIP discarded in favor of master. Follow-ups: #21921 (NestedJIT toString strlen), #21922 (multi-key wire).