Regression: session_start() AOT aborts in SessionCreateIdJitHelper::randomIdString — nested VmSession::createId (#1974)

[PurHur]

Category

stdlib · php-src-strict · blocks #1974 deploy smoke

Problem

After #21870, examples/005-SessionsWeb links but AOT execute aborts (exit 134) inside nested-JIT SessionCreateIdJitHelper::randomIdString. Binary strings show return-type errors attributing phpcompiler\ext\standard\vmsession where a string is required — nested static VmSession::createId() is mis-lowered.

Repro	Expected	AOT (post-#21870)
session_start(); echo "ok\n";	prints ok	SIGABRT in randomIdString
test005SessionsWebAotLink	green	green
SessionsWebAotExecuteTest	green	fail exit 134

php-src reference

• php/php-src ext/session/session.c — php_session_create_id / bin_to_readable

PHP implementation target

• ext/standard/SessionCreateIdJitHelper.php — avoid nested VmSession::createId(); use random_bytes + local bin_to_readable (or fix NestedJIT static call return)
• lib/JIT/Builtin/SessionCreateIdRuntime.php — bridge remains

Repro

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
printf "%s\n" "<?php" "session_start();" "echo \"ok\\n\";" > /tmp/ss.php
php bin/compile.php -o /tmp/ss.bin /tmp/ss.php
PHP_COMPILER_SESSION_DIR=$(mktemp -d) /tmp/ss.bin; echo exit:$?
'

Done when

• Minimal AOT session_start() prints and exits 0
• SessionsWebAotExecuteTest green
• php-src-strict; no new C runtime

[PurHur]

claim: PHP Compiler STD Lib Advanced — batch (#21892; unblocks #1974 execute)

[PurHur]

Merged in #21899 — AOT session_start() no longer aborts; $r = session_start() is true (bool value-box copy fix).

Set-Cookie still missing on thin AOT (link stubs); follow-up filed for NestedJIT PendingHeaders upgrade. Progress #1974.