You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#1865 / #1928 landed script/north-star2-verify.sh and make north-star2-verify, but NORTH_STAR2_VERIFY_GATE still defaults to 0 in script/ci-defaults.env. Contributors must remember opt-in env for the NS2 presenter in ci-fast.sh; ci-common.sh prints a skip message referencing stale “pending #1865”.
North Star 1 presenter (NORTH_STAR1 / #1845) is the model: default-on when stable, opt-out for iteration.
Goal
When make north-star2-verify passes on master with LLVM 9 (or skips LLVM tail cleanly):
Set NORTH_STAR2_VERIFY_GATE=1 default in script/ci-defaults.env
ci-fast.sh runs ci_run_north_star2_verify() without opt-in
Opt-out: NORTH_STAR2_VERIFY_GATE=0 ./script/ci-fast.sh for doc-only / no-LLVM hosts
Problem
#1865 / #1928 landed
script/north-star2-verify.shandmake north-star2-verify, butNORTH_STAR2_VERIFY_GATEstill defaults to 0 inscript/ci-defaults.env. Contributors must remember opt-in env for the NS2 presenter inci-fast.sh;ci-common.shprints a skip message referencing stale “pending #1865”.North Star 1 presenter (
NORTH_STAR1/ #1845) is the model: default-on when stable, opt-out for iteration.Goal
When
make north-star2-verifypasses onmasterwith LLVM 9 (or skips LLVM tail cleanly):NORTH_STAR2_VERIFY_GATE=1default inscript/ci-defaults.envci-fast.shrunsci_run_north_star2_verify()without opt-inNORTH_STAR2_VERIFY_GATE=0 ./script/ci-fast.shfor doc-only / no-LLVM hostsdocs/local-ci-matrix.md,docs/bootstrap-selfhost.md,lib/Doctor.phpgate text (remove “pending DevEx: make north-star2-verify presenter gate (self-host M0–M4) #1865”)test/unit/CiScriptsTest.phpasserts default:-1Implementation hints
script/ci-defaults.envNORTH_STAR2_VERIFY_GATE="${NORTH_STAR2_VERIFY_GATE:-1}"script/ci-common.shscript/ci-docker-run.shlib/Doctor.phpdocs/local-ci-matrix.md0→1Acceptance criteria
No GitHub Actions required.
Dependencies
--strict/ partial skips)Links