Skip to content

CI: NORTH_STAR2_VERIFY_GATE default-on in ci-fast (prereq #1865 ✅) #2051

Description

@PurHur

Problem

#1865 / #1928 landed script/north-star2-verify.sh and make north-star2-verify, but NORTH_STAR2_VERIFY_GATE still defaults to 0 in script/ci-defaults.env. Contributors must remember opt-in env for the NS2 presenter in ci-fast.sh; ci-common.sh prints a skip message referencing stale “pending #1865”.

North Star 1 presenter (NORTH_STAR1 / #1845) is the model: default-on when stable, opt-out for iteration.

Goal

When make north-star2-verify passes on master with LLVM 9 (or skips LLVM tail cleanly):

  1. Set NORTH_STAR2_VERIFY_GATE=1 default in script/ci-defaults.env
  2. ci-fast.sh runs ci_run_north_star2_verify() without opt-in
  3. Opt-out: NORTH_STAR2_VERIFY_GATE=0 ./script/ci-fast.sh for doc-only / no-LLVM hosts
  4. Update docs/local-ci-matrix.md, docs/bootstrap-selfhost.md, lib/Doctor.php gate text (remove “pending DevEx: make north-star2-verify presenter gate (self-host M0–M4) #1865”)
  5. test/unit/CiScriptsTest.php asserts default :-1

Implementation hints

File Change
script/ci-defaults.env NORTH_STAR2_VERIFY_GATE="${NORTH_STAR2_VERIFY_GATE:-1}"
script/ci-common.sh Skip message → opt-out wording
script/ci-docker-run.sh Pass env through
lib/Doctor.php NS2 ci-fast row default-on
docs/local-ci-matrix.md Gate table 01

Acceptance criteria

./script/ci-fast.sh   # includes north-star2-verify when script exists
NORTH_STAR2_VERIFY_GATE=0 ./script/ci-fast.sh   # skips presenter
docker run --rm -v "$(pwd):/compiler" -w /compiler php-compiler:22.04-dev ./script/ci-fast.sh

No GitHub Actions required.

Dependencies

Links

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions