Repository navigation
Regression: extract() EXTR_OVERWRITE duplicate keys — first value wins not last (ext/standard/basic_functions.c) #13722
Description
Category
stdlib · php-src-strict
Problem
When extract() receives an array literal with duplicate string keys, EXTR_OVERWRITE must apply entries in order so the last value wins (php-src walks the array sequentially).
VM keeps the first value instead.
php-src reference
ext/standard/basic_functions.c—PHP_FUNCTION(extract),EXTR_OVERWRITEbranch
Repro (verified 2026-06-29)
<?php
declare(strict_types=1);
extract(['a' => 1, 'a' => 2], EXTR_OVERWRITE);
var_export($a);
echo "\nok\n";./script/docker-exec.sh -- bash -lc 'php test/repro/maintainer_gap_extract_extr_overwrite_duplicate.php'
./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/maintainer_gap_extract_extr_overwrite_duplicate.php'| Check | Zend | VM |
|---|---|---|
$a after duplicate-key EXTR_OVERWRITE |
2 |
1 |
Note: EXTR_SKIP duplicate-key behavior already matches (2).
Scope (PHP-in-PHP first)
| Layer | Path |
|---|---|
| VM builtin | ext/standard/extract.php, ext/standard/VmExtract.php (or equivalent helper) |
| Hash iteration | ensure duplicate keys in inline/literal arrays preserve last-wins order |
| JIT/AOT | mirror after VM guard green |
Done when (php-src-strict)
- Duplicate-key
EXTR_OVERWRITElast value wins - Other
EXTR_*modes unchanged -
test/repro/maintainer_gap_extract_extr_overwrite_duplicate.phpexits 0 on VM
Verification
php bin/vm.php test/repro/maintainer_gap_extract_extr_overwrite_duplicate.php
Activity
PurHur commentedon Jun 29, 2026
claim: PHP Runtime → PHP — batch (issues #13722, #10547)
PurHur commentedon Jun 29, 2026
claim: PHP Runtime → PHP — batch (issues #13748, #13750, #13722)
PurHur commentedon Jun 29, 2026
Verified on master (2026-06-29): VM returns 2 for duplicate-key EXTR_OVERWRITE — matches Zend. Closing candidate.
PurHur commentedon Jun 29, 2026
claim: PHP Compiler STD Lib — batch (issue #13722, continuing after #13800 merge)
PurHur commentedon Jun 29, 2026
Verified on master after #13807 merge: duplicate-key EXTR_OVERWRITE repro returns
2on VM (matches Zend). No code change needed — please close if still open.PurHur commentedon Jun 30, 2026
claim: PHP Runtime → PHP — batch (issues #14103, #13722)
PurHur commentedon Jun 30, 2026
Closing as stale: repro green on master 2026-06-30 (verified by PHP Runtime migration run after #14222).