Repository navigation
fix: meaningful recordings integration tests - #885
Merged
Merged
Conversation
Contributor
|
Size Change: 0 B Total Size: 719 kB ℹ️ View Unchanged
|
pauldambra
added a commit
that referenced
this pull request
Nov 12, 2023
Comment on lines
+235
to
+236
| // even though we trigger 4 events, only 2 snapshots should be captured | ||
| // I _think_ this is because Cypress is faking things and they happen too fast |
Contributor
There was a problem hiding this comment.
This is more rrweb than cypress. It doesn't capture every single mousemove event, rather it smooths it out and captures sampled movements
pauldambra
commented
Nov 13, 2023
pauldambra
commented
Nov 13, 2023
pauldambra
commented
Nov 13, 2023
pauldambra
commented
Nov 13, 2023
pauldambra
commented
Nov 13, 2023
pauldambra
commented
Nov 13, 2023
pauldambra
commented
Nov 13, 2023
pauldambra
commented
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to get to a place where the session id bug fixed in #878 would be impossible to merge.
Our session recording integration tests currently check that
They don't even have to be $snapshot events let alone correct $snapshot events 🙈
This changes the integration tests to look at what was captured and make some assertions on the content.
It wouldn't protect us from that specific bug we can build on this much more easily