Repository navigation
fix: session id should start null - #878
Merged
Merged
Conversation
Contributor
|
Size Change: +334 B (0%) Total Size: 719 kB
ℹ️ View Unchanged
|
pauldambra
changed the title
pauldambra
marked this pull request as ready for review
November 7, 2023 20:46
pauldambra
marked this pull request as draft
November 8, 2023 08:11
pauldambra
marked this pull request as ready for review
November 8, 2023 09:12
benjackwhite
approved these changes
Nov 8, 2023
benjackwhite
left a comment
benjackwhite
left a comment
Contributor
There was a problem hiding this comment.
I think this makes sense 👍
This was referenced Nov 10, 2023
pauldambra
added a commit
that referenced
this pull request
Nov 13, 2023
I want to get to a place where the session id bug fixed in #878 would be impossible to merge. Our session recording integration tests currently check that when you type in a box PostHog sends two things to capture They don't even have to be $snapshot events let alone correct $snapshot events 🙈 This changes the integration tests to look at what was captured and make some assertions on the content. It wouldn't protect us from that specific bug we can build on this much more easily
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe the change from starting with null session id was too excitable...
With the session id starting as null we're less likely to pick up a previous session as continuing incorrectly and are more consistent taking a full snapshot when the session starts.
Tested by