Skip to content

fix: tolerate undefined target #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raquelmsmith merged 1 commit into from
Mar 2, 2023
Merged

fix: tolerate undefined target #565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/autocapture-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ export function getDirectAndNestedSpanText(target: Element): string {
*/
export function getNestedSpanText(target: Element): string {
let text = ''
if (target.children?.length > 0) {
if (target && target.children?.length > 0) {

@pauldambra pauldambra Mar 2, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a nice balance between the legible version and the paranoid version.

It's a really tricky balance. If we never trust TS then what's the point of using it, but it's JS that runs in the browser and we know that'll do the stupidest thing at least 50% of the time 🤣

@raquelmsmith raquelmsmith Mar 2, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

for (const child of target.children) {
if (child && child.nodeType === 1 && child.tagName.toLowerCase() === 'span') {
const spanText = getSafeText(child)
Expand Down