Repository navigation
fix: tolerate undefined target - #565
Merged
Merged
Conversation
Contributor
|
Size Change: +12 B (0%) Total Size: 2.28 MB
ℹ️ View Unchanged
|
pauldambra
approved these changes
Mar 2, 2023
| export function getNestedSpanText(target: Element): string { | ||
| let text = '' | ||
| if (target.children?.length > 0) { | ||
| if (target && target.children?.length > 0) { |
Member
There was a problem hiding this comment.
I think it's a nice balance between the legible version and the paranoid version.
It's a really tricky balance. If we never trust TS then what's the point of using it, but it's JS that runs in the browser and we know that'll do the stupidest thing at least 50% of the time 🤣
6 of 24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
@pauldambra doesn't trust typescript and neither should I. See #563 (comment)
...
Checklist