Repository navigation
feat: sync main 1.39 into v1 - #405
Merged
Merged
Conversation
…#396) * feat(flags): report unresolved local flags on EvaluateFlags snapshots Implements the "Snapshot unresolved flag reporting" and "Warning for flags local evaluation never resolves" requirements of the evaluate-flags spec (PostHog/sdk-specs#85). - Add `FeatureFlagEvaluations.UnresolvedFlags()`, with an `UnresolvedFlagReason` for each flag and the spec's fixed precedence. - Report `local_evaluation_inconclusive` instead of `flag_missing` when a snapshot read hits an unresolved flag. - Do not stop a condition at the first inconclusive filter, so a filter that does not match resolves the condition locally. - Check `Active` before experience continuity. - Log one warning per flag that local evaluation can never resolve, repeated only when its definition changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 39793b31-809e-4689-a5d8-b4359cbb22c1 * fix(flags): address review findings for unresolved local flags * fix(flags): sort payload keys when fingerprinting unresolvable flags * test(flags): cover server fallback when a flag dependency needs server data * fix(flags): rank unresolved reasons across the whole flag on server fallback * fix(flags): report a missing group key as missing context (cherry picked from commit 401e68f)
v2 sends events to the capture v1 endpoint, which needs a success body for the client to report delivery. Use the shared serveCaptureOK helper as the other evaluation test servers do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit e13d11c)
Bumps the github-actions group with 2 updates: [github/codeql-action/init](https://github.com/github/codeql-action) and [github/codeql-action/analyze](https://github.com/github/codeql-action). Updates `github/codeql-action/init` from 4.39.0 to 4.39.1 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@6f2ac81...9b32540) Updates `github/codeql-action/analyze` from 4.39.0 to 4.39.1 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@6f2ac81...9b32540) --- updated-dependencies: - dependency-name: github/codeql-action/init dependency-version: 4.39.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: github/codeql-action/analyze dependency-version: 4.39.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit fee6566)
marandaneto
reviewed
Nov 2, 2026
marandaneto
left a comment
marandaneto
left a comment
Member
There was a problem hiding this comment.
Automated advisory code review.
turnipdabeets
approved these changes
Nov 2, 2026
turnipdabeets
left a comment
turnipdabeets
left a comment
Contributor
There was a problem hiding this comment.
[suggestion] The two findings from the automated review are in #396's code, which is the same on main, so this sync didn't introduce them. We should fix them on main and carry the fix into v1 with the next sync.
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
mainreleased 1.39.0 after the last sync (#390), so v2 would drop its new flags API (UnresolvedFlags,UnresolvedFlagReason*,FeatureFlagErrorLocalEvaluationInconclusiveand theReasonfields) and break 1.39 users on upgrade.Changes
-xpicks of everything after feat!: sync main 1.35-1.38 into v1, release otel with the core major #390's last pick (b0a9fae..fee6566): feat(flags): report unresolved local flags on EvaluateFlags snapshots #396, the 1.39.0 release commit and chore(deps): bump the github-actions group with 2 updates #402. Nothing is left out.otelandposthogmcpsdkrequirement onposthog-go/v2; that is its only difference frommain.💚 How did you test it?
go test ./...,go vet ./...,gofmtandgo mod tidyin the root,otelandposthogmcpsdkmodules;make api-diffup to date.go test ./....📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
claude-opus-5-5), following the release runbook's main-sync step and feat!: sync main 1.35-1.38 into v1, release otel with the core major #390's method.🤖 Generated with Claude Code